lib/streamaggr: added rate and rate_avg output #6243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewChubatiuk
force-pushed
the
support-rate
branch
from
5ebc793
to
1944c62
Compare
hagen1778
reviewed
May 8, 2024
AndrewChubatiuk
force-pushed
the
support-rate
branch
2 times, most recently
from
399aed9
to
b66106d
Compare
AndrewChubatiuk
force-pushed
the
support-rate
branch
2 times, most recently
from
dc642e3
to
4cca78b
Compare
AndrewChubatiuk
force-pushed
the
support-rate
branch
4 times, most recently
from
29ebf00
to
e082d3e
Compare
AndrewChubatiuk
changed the title
|
@hagen1778 tested on a sandbox, resource usage for rate is almost the same as for increase |
AndrewChubatiuk
force-pushed
the
support-rate
branch
from
bbc916d
to
6843e11
Compare
|
@AndrewChubatiuk would you mind checking 8b10330 ? If you agree with changes then we can merge this pr. |
* rename `rate` to `rate_sum` for sake of consistency * rename `startTimestamp` to `prevTimestamp` for clarity * capture number of unique series for `rate_avg` calculation after stale series were removed Signed-off-by: hagen1778 <roman@victoriametrics.com>
Signed-off-by: hagen1778 <roman@victoriametrics.com>
hagen1778
pushed a commit
that referenced
this pull request
May 13, 2024
Added `rate` and `rate_avg` output Resource usage is the same as for increase output, tested on a benchmark --------- Signed-off-by: hagen1778 <roman@victoriametrics.com> Co-authored-by: hagen1778 <roman@victoriametrics.com> (cherry picked from commit 9c3d44c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Added
rateandrate_avgoutputResource usage is the same as for increase output, tested on a benchmark
Checklist
The following checks are mandatory: