Fix mobile bugs related to resizing and styling #405
+70
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
szeckirjr
changed the title
|
|
||
| export function ImportTimetable(): JSX.Element { | ||
| const { slug } = useParams(); | ||
| const smallScreen = useSmallScreen(); | ||
|
|
||
| const { loading, data } = useGetTimetable({ slug: slug }); | ||
| const [courses, setCourses] = useState<TimetableCourse[]>([]); | ||
| const [term, setTerm] = useState<Term>('202205'); |
There was a problem hiding this comment.
getCurrentTerm() probably better here instead of hard coding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #407
Proposal for fixing visual layout of import page on mobile to make use of sidebars and remove redundant buttons.
Removing right sidebar, as it simply showed list of courses, which is accessible on main page. Also added timetable tags to the left sidebar along with the actions.
This also fixes the Swiper error on resizing, and now aligns with the page properly.
Screenshots
Before
After
Checklist
General Comments
Would it be useful to add timetable cards underneath for "Your Timetable Courses" to show the user what they have saved currently?