Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort search results #506

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

zakariyavkhan
Copy link

Description

Sort the course search results by subject and course number.

Closes #505

Screenshots

Before

Screenshot 2023-10-31 at 19-08-18 CourseUp

After

Screenshot 2023-10-31 at 19-10-28 CourseUp

Checklist

  • The code follows all style guidelines.
  • The code passes all required tests.
  • The code is documented.
  • The code includes tests.
  • I have self-reviewed my changes and have done QA.

General Comments

@zakariyavkhan zakariyavkhan requested a review from a team as a code owner November 1, 2023 02:37
Copy link

vercel bot commented Nov 1, 2023

@zakariyavkhan is attempting to deploy a commit to the VikeLabs Team on Vercel.

A member of the Team first needs to authorize it.

@aomi
Copy link
Member

aomi commented Nov 11, 2023

I think to do this feature well, it will need to be considered carefully. Right now the search is all handled by Algolia with some minor tweaks to make it easier to use.

I can think of some situations where this breaks. Since this is anything search, if there's results that are for different subjects it will mess with them. If you are searching for a course within the same subject it messes with the order.

I would consider only engaging this sorting behaviour when there's explicit conditions met like the user is searching for just the subject. Just my two cents. Search is hard :|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Lexicographically sort search results by course code
2 participants