Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CU-86934hnmg rest api skipping fields #252

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

CodeVoyager
Copy link
Contributor

Ticket

#239

Summary

What does this PR do/solve?

  • fields of comment entity can be skipped

Test Plan

  • start the server
  • make a API call like http://localhost:1337/api/comments/<id>?omit[]=blocked&omit[]=related&omit[]=author
  • response should not contain specified fields

@CodeVoyager CodeVoyager added the enhancement New feature or request label Mar 16, 2024
@CodeVoyager CodeVoyager self-assigned this Mar 16, 2024
@cyp3rius
Copy link
Collaborator

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.90%. Comparing base (2a49049) to head (cd39582).

Files Patch % Lines
server/services/common.ts 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
- Coverage   80.97%   80.90%   -0.08%     
==========================================
  Files          35       35              
  Lines         946      953       +7     
  Branches      316      321       +5     
==========================================
+ Hits          766      771       +5     
- Misses        176      178       +2     
  Partials        4        4              
Flag Coverage Δ
unittest 80.90% <92.30%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cyp3rius cyp3rius merged commit 03f05f7 into master May 29, 2024
3 checks passed
@cyp3rius cyp3rius deleted the feat/omit-fields branch May 29, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants