Build cleanup and Mill update to 0.11.5 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also avoids defining a `T.command` inside of a class which does not extend `mill.define.Module`.
This not only makes them accessible from the CLI, it also fixes an issue with Mill 0.11.{2-5}.
See com-lihaoyi/mill#2844
tgodzik
approved these changes
Nov 21, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies test helper code. This especially avoids defining a
T.commandinside of a inner class which does not extendmill.define.Module.I also removed some recursive logic by reusing the upstream
transitiveModuleDeps, which is itself tail recursive and properly checked for cycles.And last but not least, I identified a workaround to com-lihaoyi/mill#2844 (see com-lihaoyi/mill#2844 (comment)) and took the opportunity to bump Mill to 0.11.5.