Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: build refactor to esm #396

Merged
merged 2 commits into from Nov 29, 2022
Merged

feat: build refactor to esm #396

merged 2 commits into from Nov 29, 2022

Conversation

AyAyEm
Copy link
Member

@AyAyEm AyAyEm commented Nov 26, 2022 •
edited

What did you fix? (provide a description or issue closes statement)

closes #268

Reproduction steps

  1. Refactored the code to ESM without changing any logic when possible

Evidence/screenshot/link to line

Considerations

  • Does this contain a new dependency? [Yes]
  • Does this introduce opinionated data formatting or manual data entry? [No]
  • Does this pr include the updated data files in a separate commit that can be reverted for a clean code-only pr? [No]
  • Have I run the linter through npm run lint? [Yes]
  • Is is a bug fix, feature request, or enhancement? [Feature]

@AyAyEm AyAyEm self-assigned this Nov 26, 2022
TobiTenno
TobiTenno requested changes Nov 27, 2022
View reviewed changes
build/.eslintrc.yaml Outdated Show resolved Hide resolved
build/parser.mjs Outdated Show resolved Hide resolved
build/sortObject.mjs Outdated Show resolved Hide resolved
build/wikia/transformers/transformPolarity.mjs Outdated Show resolved Hide resolved
build/wikia/transformers/transformWarframe.mjs Outdated Show resolved Hide resolved
build/wikia/transformers/transformWarframe.mjs Outdated Show resolved Hide resolved
TobiTenno
TobiTenno requested changes Nov 28, 2022
View reviewed changes
build/build.mjs Outdated Show resolved Hide resolved
build/wikia/transformers/elements.mjs Outdated Show resolved Hide resolved
@AyAyEm
Copy link
Member Author

AyAyEm commented Nov 29, 2022

I made everything again by hand so no renaming this time.

@AyAyEm AyAyEm marked this pull request as ready for review November 29, 2022 01:54
@AyAyEm AyAyEm requested a review from a team as a code owner November 29, 2022 01:54
TobiTenno
TobiTenno reviewed Nov 29, 2022
View reviewed changes
build/.eslintrc.yaml Outdated Show resolved Hide resolved
TobiTenno
TobiTenno approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@TobiTenno TobiTenno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot

@TobiTenno TobiTenno merged commit ae5c51c into master Nov 29, 2022
@TobiTenno TobiTenno deleted the build-conversion-to-es branch November 29, 2022 23:13
@wfcd-bot-boi
Copy link
Collaborator

🎉 This PR is included in version 1.1258.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiTenno TobiTenno TobiTenno approved these changes

Assignees

@AyAyEm AyAyEm

Labels
released Type: Enhancement Improves existing feature Type: Feature Request Type: Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🕥 Convert warframe-items to ES
3 participants
@AyAyEm @wfcd-bot-boi @TobiTenno