Strict Mode #243
Closed
Strict Mode #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the required peer dependency to be greater than 16.7
Use the `useState` function in order to manage state within the Incrementer component. Change from a class implementation to a function implementation.
Update the DropdownButton component to use hooks to manage state of whether or not the dropdown is open. Use createRef to manage refs.
Update TabPanel component to use hooks to manage state.
Change the ToggleButton component to a function component that uses the useState function to manage its state.
The DatePickerTextbox was moved directly into the DatePicker component. Use React.createRef in order to manage refs instead of a function.
Use hooks where currently applicable
Updated react-datepicker
* Removing build script that generates the lib directory * Changing babel config to use modules: 'auto' only for jest
Latest preset (2.3.1) uses the recently introduced babelrc configs as defaults. .babelrc.js has been updated accordingly
Remove commonjs build
Use Rollup For esmodule build
withTheme requires components that need access to the theme to receive it as a prop. This is unnecessary as theme is provided via context and creates confusion and bloat as to where theme is supposed to be derived from.
Styled Components v4
Create three different types of notifications. 1. Notification - the default notification type 2. LightNotification - notifications with light backgrounds 3. MessageNotification - notifications with no backgrounds These components have a smaller public API in order to reduce the complexity of the Notification component. Calls to action have been removed and will be added to the Patterns section as their own standalone component.
Add CallToAction and LightCallToAction components to the patterns section. The Action component is a wrapper to append some styling and the isPrimary prop is used to drive the styleType that gets passed to the Button component inside each CallToAction component.
New notifications and Calls To Action
jrios
force-pushed
the
next
branch
2 times, most recently
from
cc46391
to
9081ea7
Compare
|
Will revisit once |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
findDOMNodeusagestyled-components- React.StrictMode throws warning because offindDOMNodeuse styled-components/styled-components#2154react-overlaysuncontrollable()hocreact-overlays