-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix some comments #4325
Merged
Merged
chore: fix some comments #4325
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kaifulee <cuishuang@outlook.com>
bkrem
approved these changes
Mar 13, 2024
thanks for the PR 💯 |
20 tasks
github-merge-queue bot
referenced
this pull request
in valora-inc/wallet
Apr 12, 2024
Loading
Loading status checks…
….12.1 (#5228) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@walletconnect/react-native-compat](https://togithub.com/walletconnect/walletconnect-monorepo) | [`^2.11.3` -> `^2.12.1`](https://renovatebot.com/diffs/npm/@walletconnect%2freact-native-compat/2.11.3/2.12.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>walletconnect/walletconnect-monorepo (@​walletconnect/react-native-compat)</summary> ### [`v2.12.1`](https://togithub.com/WalletConnect/walletconnect-monorepo/releases/tag/2.12.1) [Compare Source](https://togithub.com/walletconnect/walletconnect-monorepo/compare/2.12.0...2.12.1) ##### What's Changed - chore: prep for `2.12.0` release by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4392](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4392) - fix: fallback event listener cleanup by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4403](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4403) - fix: handle `loadPersistedSession` exceptions by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4404](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4404) **Full Changelog**: WalletConnect/walletconnect-monorepo@2.12.0...2.12.1 ### [`v2.12.0`](https://togithub.com/WalletConnect/walletconnect-monorepo/releases/tag/2.12.0) [Compare Source](https://togithub.com/walletconnect/walletconnect-monorepo/compare/2.11.3...2.12.0) ##### What's Changed - feat: add visionOS support by [@​thiagobrez](https://togithub.com/thiagobrez) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4340](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4340) - chore: prep for 2.11.3 release by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4343](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4343) - fix: optimize cleanup by [@​chris13524](https://togithub.com/chris13524) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4351](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4351) - chore: add code to for chunk logging by [@​devceline](https://togithub.com/devceline) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4342](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4342) - fix: adds `http://` support for deeplinks by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4349](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4349) - feat: optionally disable deeplinks by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4373](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4373) - chore: fix some comments by [@​kaifulee](https://togithub.com/kaifulee) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4325](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4325) - feat: updates session without waiting for an ack from the peer by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4346](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4346) - chore(deps): update actions/add-to-project action to v0.6.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4354](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4354) - chore(deps): update actions/add-to-project action to v1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4380](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4380) - feat: auth aka sign 2.5 by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4331](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4331) ##### New Contributors - [@​thiagobrez](https://togithub.com/thiagobrez) made their first contribution in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4340](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4340) - [@​chris13524](https://togithub.com/chris13524) made their first contribution in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4351](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4351) - [@​kaifulee](https://togithub.com/kaifulee) made their first contribution in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4325](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4325) **Full Changelog**: WalletConnect/walletconnect-monorepo@2.11.3...2.12.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
github-merge-queue bot
referenced
this pull request
in valora-inc/wallet
Apr 12, 2024
Loading
Loading status checks…
….12.1 (#5228) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@walletconnect/react-native-compat](https://togithub.com/walletconnect/walletconnect-monorepo) | [`^2.11.3` -> `^2.12.1`](https://renovatebot.com/diffs/npm/@walletconnect%2freact-native-compat/2.11.3/2.12.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>walletconnect/walletconnect-monorepo (@​walletconnect/react-native-compat)</summary> ### [`v2.12.1`](https://togithub.com/WalletConnect/walletconnect-monorepo/releases/tag/2.12.1) [Compare Source](https://togithub.com/walletconnect/walletconnect-monorepo/compare/2.12.0...2.12.1) ##### What's Changed - chore: prep for `2.12.0` release by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4392](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4392) - fix: fallback event listener cleanup by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4403](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4403) - fix: handle `loadPersistedSession` exceptions by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4404](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4404) **Full Changelog**: WalletConnect/walletconnect-monorepo@2.12.0...2.12.1 ### [`v2.12.0`](https://togithub.com/WalletConnect/walletconnect-monorepo/releases/tag/2.12.0) [Compare Source](https://togithub.com/walletconnect/walletconnect-monorepo/compare/2.11.3...2.12.0) ##### What's Changed - feat: add visionOS support by [@​thiagobrez](https://togithub.com/thiagobrez) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4340](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4340) - chore: prep for 2.11.3 release by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4343](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4343) - fix: optimize cleanup by [@​chris13524](https://togithub.com/chris13524) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4351](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4351) - chore: add code to for chunk logging by [@​devceline](https://togithub.com/devceline) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4342](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4342) - fix: adds `http://` support for deeplinks by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4349](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4349) - feat: optionally disable deeplinks by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4373](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4373) - chore: fix some comments by [@​kaifulee](https://togithub.com/kaifulee) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4325](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4325) - feat: updates session without waiting for an ack from the peer by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4346](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4346) - chore(deps): update actions/add-to-project action to v0.6.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4354](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4354) - chore(deps): update actions/add-to-project action to v1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4380](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4380) - feat: auth aka sign 2.5 by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4331](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4331) ##### New Contributors - [@​thiagobrez](https://togithub.com/thiagobrez) made their first contribution in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4340](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4340) - [@​chris13524](https://togithub.com/chris13524) made their first contribution in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4351](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4351) - [@​kaifulee](https://togithub.com/kaifulee) made their first contribution in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4325](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4325) **Full Changelog**: WalletConnect/walletconnect-monorepo@2.11.3...2.12.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
github-merge-queue bot
referenced
this pull request
in valora-inc/wallet
Apr 12, 2024
Loading
Loading status checks…
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@walletconnect/utils](https://togithub.com/walletconnect/walletconnect-monorepo) | [`^2.11.3` -> `^2.12.1`](https://renovatebot.com/diffs/npm/@walletconnect%2futils/2.11.3/2.12.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>walletconnect/walletconnect-monorepo (@​walletconnect/utils)</summary> ### [`v2.12.1`](https://togithub.com/WalletConnect/walletconnect-monorepo/releases/tag/2.12.1) [Compare Source](https://togithub.com/walletconnect/walletconnect-monorepo/compare/2.12.0...2.12.1) #### What's Changed - chore: prep for `2.12.0` release by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4392](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4392) - fix: fallback event listener cleanup by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4403](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4403) - fix: handle `loadPersistedSession` exceptions by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4404](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4404) **Full Changelog**: WalletConnect/walletconnect-monorepo@2.12.0...2.12.1 ### [`v2.12.0`](https://togithub.com/WalletConnect/walletconnect-monorepo/releases/tag/2.12.0) [Compare Source](https://togithub.com/walletconnect/walletconnect-monorepo/compare/2.11.3...2.12.0) ##### What's Changed - feat: add visionOS support by [@​thiagobrez](https://togithub.com/thiagobrez) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4340](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4340) - chore: prep for 2.11.3 release by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4343](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4343) - fix: optimize cleanup by [@​chris13524](https://togithub.com/chris13524) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4351](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4351) - chore: add code to for chunk logging by [@​devceline](https://togithub.com/devceline) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4342](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4342) - fix: adds `http://` support for deeplinks by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4349](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4349) - feat: optionally disable deeplinks by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4373](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4373) - chore: fix some comments by [@​kaifulee](https://togithub.com/kaifulee) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4325](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4325) - feat: updates session without waiting for an ack from the peer by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4346](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4346) - chore(deps): update actions/add-to-project action to v0.6.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4354](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4354) - chore(deps): update actions/add-to-project action to v1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4380](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4380) - feat: auth aka sign 2.5 by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4331](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4331) ##### New Contributors - [@​thiagobrez](https://togithub.com/thiagobrez) made their first contribution in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4340](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4340) - [@​chris13524](https://togithub.com/chris13524) made their first contribution in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4351](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4351) - [@​kaifulee](https://togithub.com/kaifulee) made their first contribution in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4325](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4325) **Full Changelog**: WalletConnect/walletconnect-monorepo@2.11.3...2.12.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Satish Ravi <satish.ravi@valoraapp.com>
github-merge-queue bot
referenced
this pull request
in valora-inc/wallet
Apr 12, 2024
Loading
Loading status checks…
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@walletconnect/utils](https://togithub.com/walletconnect/walletconnect-monorepo) | [`^2.11.3` -> `^2.12.1`](https://renovatebot.com/diffs/npm/@walletconnect%2futils/2.11.3/2.12.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>walletconnect/walletconnect-monorepo (@​walletconnect/utils)</summary> ### [`v2.12.1`](https://togithub.com/WalletConnect/walletconnect-monorepo/releases/tag/2.12.1) [Compare Source](https://togithub.com/walletconnect/walletconnect-monorepo/compare/2.12.0...2.12.1) #### What's Changed - chore: prep for `2.12.0` release by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4392](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4392) - fix: fallback event listener cleanup by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4403](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4403) - fix: handle `loadPersistedSession` exceptions by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4404](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4404) **Full Changelog**: WalletConnect/walletconnect-monorepo@2.12.0...2.12.1 ### [`v2.12.0`](https://togithub.com/WalletConnect/walletconnect-monorepo/releases/tag/2.12.0) [Compare Source](https://togithub.com/walletconnect/walletconnect-monorepo/compare/2.11.3...2.12.0) ##### What's Changed - feat: add visionOS support by [@​thiagobrez](https://togithub.com/thiagobrez) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4340](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4340) - chore: prep for 2.11.3 release by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4343](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4343) - fix: optimize cleanup by [@​chris13524](https://togithub.com/chris13524) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4351](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4351) - chore: add code to for chunk logging by [@​devceline](https://togithub.com/devceline) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4342](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4342) - fix: adds `http://` support for deeplinks by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4349](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4349) - feat: optionally disable deeplinks by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4373](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4373) - chore: fix some comments by [@​kaifulee](https://togithub.com/kaifulee) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4325](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4325) - feat: updates session without waiting for an ack from the peer by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4346](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4346) - chore(deps): update actions/add-to-project action to v0.6.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4354](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4354) - chore(deps): update actions/add-to-project action to v1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4380](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4380) - feat: auth aka sign 2.5 by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4331](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4331) ##### New Contributors - [@​thiagobrez](https://togithub.com/thiagobrez) made their first contribution in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4340](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4340) - [@​chris13524](https://togithub.com/chris13524) made their first contribution in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4351](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4351) - [@​kaifulee](https://togithub.com/kaifulee) made their first contribution in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4325](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4325) **Full Changelog**: WalletConnect/walletconnect-monorepo@2.11.3...2.12.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Satish Ravi <satish.ravi@valoraapp.com>
shottah
referenced
this pull request
in zed-io/kolektivo
May 15, 2024
….12.1 (valora-inc#5228) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@walletconnect/react-native-compat](https://togithub.com/walletconnect/walletconnect-monorepo) | [`^2.11.3` -> `^2.12.1`](https://renovatebot.com/diffs/npm/@walletconnect%2freact-native-compat/2.11.3/2.12.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>walletconnect/walletconnect-monorepo (@​walletconnect/react-native-compat)</summary> ### [`v2.12.1`](https://togithub.com/WalletConnect/walletconnect-monorepo/releases/tag/2.12.1) [Compare Source](https://togithub.com/walletconnect/walletconnect-monorepo/compare/2.12.0...2.12.1) ##### What's Changed - chore: prep for `2.12.0` release by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4392](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4392) - fix: fallback event listener cleanup by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4403](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4403) - fix: handle `loadPersistedSession` exceptions by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4404](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4404) **Full Changelog**: WalletConnect/walletconnect-monorepo@2.12.0...2.12.1 ### [`v2.12.0`](https://togithub.com/WalletConnect/walletconnect-monorepo/releases/tag/2.12.0) [Compare Source](https://togithub.com/walletconnect/walletconnect-monorepo/compare/2.11.3...2.12.0) ##### What's Changed - feat: add visionOS support by [@​thiagobrez](https://togithub.com/thiagobrez) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4340](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4340) - chore: prep for 2.11.3 release by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4343](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4343) - fix: optimize cleanup by [@​chris13524](https://togithub.com/chris13524) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4351](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4351) - chore: add code to for chunk logging by [@​devceline](https://togithub.com/devceline) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4342](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4342) - fix: adds `http://` support for deeplinks by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4349](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4349) - feat: optionally disable deeplinks by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4373](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4373) - chore: fix some comments by [@​kaifulee](https://togithub.com/kaifulee) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4325](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4325) - feat: updates session without waiting for an ack from the peer by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4346](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4346) - chore(deps): update actions/add-to-project action to v0.6.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4354](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4354) - chore(deps): update actions/add-to-project action to v1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4380](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4380) - feat: auth aka sign 2.5 by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4331](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4331) ##### New Contributors - [@​thiagobrez](https://togithub.com/thiagobrez) made their first contribution in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4340](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4340) - [@​chris13524](https://togithub.com/chris13524) made their first contribution in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4351](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4351) - [@​kaifulee](https://togithub.com/kaifulee) made their first contribution in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4325](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4325) **Full Changelog**: WalletConnect/walletconnect-monorepo@2.11.3...2.12.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
shottah
referenced
this pull request
in zed-io/kolektivo
May 15, 2024
…inc#5229) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@walletconnect/utils](https://togithub.com/walletconnect/walletconnect-monorepo) | [`^2.11.3` -> `^2.12.1`](https://renovatebot.com/diffs/npm/@walletconnect%2futils/2.11.3/2.12.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>walletconnect/walletconnect-monorepo (@​walletconnect/utils)</summary> ### [`v2.12.1`](https://togithub.com/WalletConnect/walletconnect-monorepo/releases/tag/2.12.1) [Compare Source](https://togithub.com/walletconnect/walletconnect-monorepo/compare/2.12.0...2.12.1) #### What's Changed - chore: prep for `2.12.0` release by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4392](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4392) - fix: fallback event listener cleanup by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4403](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4403) - fix: handle `loadPersistedSession` exceptions by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4404](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4404) **Full Changelog**: WalletConnect/walletconnect-monorepo@2.12.0...2.12.1 ### [`v2.12.0`](https://togithub.com/WalletConnect/walletconnect-monorepo/releases/tag/2.12.0) [Compare Source](https://togithub.com/walletconnect/walletconnect-monorepo/compare/2.11.3...2.12.0) ##### What's Changed - feat: add visionOS support by [@​thiagobrez](https://togithub.com/thiagobrez) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4340](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4340) - chore: prep for 2.11.3 release by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4343](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4343) - fix: optimize cleanup by [@​chris13524](https://togithub.com/chris13524) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4351](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4351) - chore: add code to for chunk logging by [@​devceline](https://togithub.com/devceline) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4342](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4342) - fix: adds `http://` support for deeplinks by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4349](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4349) - feat: optionally disable deeplinks by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4373](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4373) - chore: fix some comments by [@​kaifulee](https://togithub.com/kaifulee) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4325](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4325) - feat: updates session without waiting for an ack from the peer by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4346](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4346) - chore(deps): update actions/add-to-project action to v0.6.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4354](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4354) - chore(deps): update actions/add-to-project action to v1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4380](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4380) - feat: auth aka sign 2.5 by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4331](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4331) ##### New Contributors - [@​thiagobrez](https://togithub.com/thiagobrez) made their first contribution in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4340](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4340) - [@​chris13524](https://togithub.com/chris13524) made their first contribution in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4351](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4351) - [@​kaifulee](https://togithub.com/kaifulee) made their first contribution in [https://github.com/WalletConnect/walletconnect-monorepo/pull/4325](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4325) **Full Changelog**: WalletConnect/walletconnect-monorepo@2.11.3...2.12.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Satish Ravi <satish.ravi@valoraapp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a brief summary of the change.
Type of change
How has this been tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your configuration.
Fixes/Resolves (Optional)
Please list any issues that are fixed by this PR in the format
#<issue number>
. If it fixes multiple issues, please put each issue in a separate line. If this Pull Request does not fix any issues, please delete this section.Examples/Screenshots (Optional)
Please attach a screenshot or screen recording of features/fixes you've implemented to verify your changes. Please also note any relevant details for your configuration. If your changes do not affect the UI, please delete this section.
Use this table template to show examples of your changes:
Checklist
Additional Information (Optional)
Please include any additional information that may be useful for the reviewer.