Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:add eip5792 methods as optional methods #4499

Merged
merged 2 commits into from
May 8, 2024

Conversation

KannuSingh
Copy link
Collaborator

Adding EIP-5792 methods on the list of optional RPC methods. These method will become part of session proposal request to wallet.
This will enable wallet supporting EIP-5792 allowing dapps to use it after session is successfully approved by the user.

@KannuSingh KannuSingh marked this pull request as ready for review May 7, 2024 15:58
Copy link

@tomiir tomiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but would wait for an approval from @ganchoradkov

Copy link
Member

@arein arein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

triple-checking: are these all just the optional methods?

@KannuSingh
Copy link
Collaborator Author

KannuSingh commented May 7, 2024

IMO Yes, it all optional methods.
And if made required_methods then wallet need to support all those, else session can't be established.

Copy link
Member

@ganchoradkov ganchoradkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🔥

@ganchoradkov ganchoradkov merged commit 6acf224 into v2.0 May 8, 2024
9 checks passed
@ganchoradkov ganchoradkov deleted the EIP-5792-methods-support branch May 8, 2024 06:40
@ganchoradkov ganchoradkov mentioned this pull request May 8, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants