Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pairing topic setter on session settle #4553

Merged
merged 3 commits into from
May 29, 2024

Conversation

ganchoradkov
Copy link
Member

Description

Reworked dapp side to set pairingTopic on its own instead of relying on being provided by session settle request

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

existing tests

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Please include any additional information that may be useful for the reviewer.

Sorry, something went wrong.

…le instead of relying on it being sent by the wallet
@arein arein added the accepted label May 23, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@ganchoradkov ganchoradkov requested review from bkrem and Cali93 May 29, 2024 08:49
@ganchoradkov ganchoradkov merged commit 92ed3fd into v2.0 May 29, 2024
9 checks passed
@ganchoradkov ganchoradkov deleted the chore/pairing-topic-setter branch May 29, 2024 09:03
@ganchoradkov ganchoradkov mentioned this pull request May 29, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants