fix: handle multiple event handlers for the same event #4560
+22
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when calling the Wallet Connect wallet's
on
function it registers theonSessionProposal
handler multiple times in thesignClient
.This causes each event to be called as many times as there are event handlers registered for the event.
This fix always calls
off
before callingon
when setting theonSessionProposal
handler.Type of change
How has this been tested?
I added a unit test which caught the issue.
Checklist
Additional Information (Optional)
The bug came up while working on safe-global/safe-wallet-monorepo#3656 and the fix is required to unblock it.