Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: metadata field required #4596

Merged
merged 7 commits into from
Jun 10, 2024
Merged

fix: metadata field required #4596

merged 7 commits into from
Jun 10, 2024

Conversation

lukaisailovic
Copy link
Contributor

@lukaisailovic lukaisailovic commented Jun 10, 2024

Description

  • Metadata validation was introduced, however in the same PR it was made required. Reverting the change and making it optional again.
  • Test to cover the state when the object is not provided

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your configuration.

Fixes/Resolves (Optional)

Please list any issues that are fixed by this PR in the format #<issue number>. If it fixes multiple issues, please put each issue in a separate line. If this Pull Request does not fix any issues, please delete this section.

Examples/Screenshots (Optional)

Please attach a screenshot or screen recording of features/fixes you've implemented to verify your changes. Please also note any relevant details for your configuration. If your changes do not affect the UI, please delete this section.

Use this table template to show examples of your changes:

Before After
Content Cell Content Cell
Content Cell Content Cell

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Please include any additional information that may be useful for the reviewer.

Sorry, something went wrong.

@lukaisailovic lukaisailovic requested a review from bkrem June 10, 2024 10:01
@arein arein added the accepted label Jun 10, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@lukaisailovic lukaisailovic requested a review from devceline June 10, 2024 11:29
@lukaisailovic lukaisailovic merged commit 5c0535a into v2.0 Jun 10, 2024
9 checks passed
@lukaisailovic lukaisailovic deleted the fix/metadata-type branch June 10, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants