Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Unify the error message in type-subtyping.wast. #504

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[test] Unify the error message in type-subtyping.wast. #504

wants to merge 1 commit into from

Conversation

q82419
Copy link
Contributor

@q82419 q82419 commented Dec 26, 2023

indirect call -> indirect call type mismatch
cast -> cast failure
incompatible import -> incompatible import type

@q82419
[test] Unify the error message in type-subtyping.wast.
82d55ae 
Signed-off-by: YiYing He <yiying@secondstate.io>
rossberg
rossberg approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine changing these, but wanted to point out that this and other message short forms were somewhat intentional, meant to make tests more robust with respect to fine-tuning of error messages in the interpreter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossberg rossberg rossberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@q82419 @rossberg