Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sanitize script #336

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

camillobruni
Copy link
Contributor

This script will eventually replace the benchmark-specifics overrides we already employ for some workloads.

  • clamp all setTimeout to 0ms delay to limit effects of CPU throttling
  • Make requestIdleCallback and cancelIdleCallback noops
  • Set a fixed userAgent string to avoid running potentially browser-specific code

The sanitize.js script is supposed to be included in all benchmarks.

@camillobruni
Copy link
Contributor Author

Using the sanitize script will happen in a separate PR, see #267 as an early example.

@camillobruni camillobruni added the trivial change A change that doesn't affect benchmark results label Dec 13, 2023
@camillobruni
Copy link
Contributor Author

As per meeting discussion, this needs some more detailed investigation on which workloads use which of these APIs.
Happy to land the non-controversial stuff first and set everything up for more common scripts we want to share between workloads.

@camillobruni camillobruni marked this pull request as draft March 6, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trivial change A change that doesn't affect benchmark results v3.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant