[fix]: update nuxt config: remove hash from file names #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flashdesignory
changed the title
rniwa
approved these changes
Mar 22, 2024
julienw
reviewed
Mar 26, 2024
Comment on lines
+46
to
+48
| chunkFileNames: "_nuxt/[name].js", | ||
| entryFileNames: "_nuxt/[name].js", | ||
| assetFileNames: "_nuxt/[name].[ext]", |
There was a problem hiding this comment.
I'm not convinced: if we do that, when we'll update the file, the old version might be served from the cache. This will lead to bugs and frustrations.
I think the hash changing is a symptom that the content changes. I'm not too concerned about the hash change, it is easy to review. I'm more concerned to know why the content changes.
That's not a super big deal. Though I wonder if removing the minify step would be acceptable, as this would make easier to review the rendered code. Set this to false in vite's configuration, though it looks like there's an option in nuxt too.
What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing nuxt config, to avoid hash in file names.
moving discussion from #400 to this pr, in regards to build files creation.
@kara