Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deconfuse Geomean Metric and geomean aggregate value #408

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Deconfuse Geomean Metric and geomean aggregate value #408

wants to merge 4 commits into from

Conversation

camillobruni
Copy link
Contributor

@camillobruni camillobruni commented May 13, 2024 •
edited

The metric's "geomean" aggregate value can be easily confused with the top-level Geomean metric (issue #407).

  • Don't serialize "geomean" in the JSON data
  • Add descriptions to Score, Geomean, and Iteration metrics that are serialized in the JSON data
  • Make the detail view titles more descriptive

@camillobruni camillobruni requested a review from julienw May 13, 2024 16:02
julienw
julienw reviewed May 14, 2024
View reviewed changes
resources/metric.mjs Show resolved Hide resolved
resources/benchmark-runner.mjs Show resolved Hide resolved
@julienw
Copy link
Contributor

julienw commented May 14, 2024

BTW the CI doesn't pass for some reason...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienw julienw julienw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@camillobruni @julienw