Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fire dblclick on disabled form control elements #20723

Merged
merged 1 commit into from
Nov 19, 2023

Commits on Nov 19, 2023

  1. Don't fire dblclick on disabled form control elements

    https://bugs.webkit.org/show_bug.cgi?id=265071
    rdar://problem/118584431
    
    Reviewed by Tim Nguyen.
    
    This patch extends to not fire double click events on disabled elements similar to click event aligning with
    Gecko / Firefox, Blink / Chromium and agreed behavior in web specification issue [1]:
    
    [1] whatwg/html#2368 (comment)
    
    * Source/WebCore/dom/EventDispatcher.cpp:
    (EventDispatcher::dispatchEvent):
    * LayoutTests/imported/w3c/web-platform-tests/html/semantics/disabled-elements/disabled-event-dispatch.tentative-expected.txt: Rebaselined
    * LayoutTests/platform/ios-simulator-16-wk2/imported/w3c/web-platform-tests/html/semantics/disabled-elements/disabled-event-dispatch.tentative-expected.txt: Rebaselined
    * LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/disabled-elements/disabled-event-dispatch.tentative-expected.txt: Rebaselined
    
    Canonical link: https://commits.webkit.org/270951@main
    Ahmad-S792 authored and Ahmad Saleem committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    74ae3ea View commit details
    Browse the repository at this point in the history