Implement toggleevents for dialog open/close #23332
Conversation
|
EWS run on previous version of this PR (hash ef08e8f) |
|
Is this is in the spec somewhere? |
Ahmad-S792
added
the
DOM
https://bugs.webkit.org/show_bug.cgi?id=268160 Reviewed by NOBODY (OOPS!). This adds the `beforetoggle` cancelable event to `show()`/`showModal()` calls. If `beforetoggle` isn't cancelled, it will show the dialog and dispatch a `toggle` event. Likewise, the close method adds a NON cancelable `beforetoggle` and `toggle` event. These events can help developers when prepping a dialog to be shown or hidden, such as doing page calculations or kicking off animations. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/toggle-events.tentative-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/toggle-events.tentative.html: Added. * Source/WebCore/html/HTMLDialogElement.cpp: (WebCore::HTMLDialogElement::show): (WebCore::HTMLDialogElement::showModal): (WebCore::HTMLDialogElement::close): (WebCore::HTMLDialogElement::queueDialogToggleEventTask): * Source/WebCore/html/HTMLDialogElement.h:
keithamus
force-pushed
the
dialog-toggle-events
branch
from
ef08e8f
to
706583c
Compare
|
EWS run on current version of this PR (hash 706583c) |
Not yet but we discussed it as TPAC and it was deemed a reasonable addition. Tentative spec PR here: whatwg/html#10091 |
| @@ -177,4 +198,21 @@ void HTMLDialogElement::setIsModal(bool newValue) | |||
| m_isModal = newValue; | |||
| } | |||
|
|
|||
| void HTMLDialogElement::queueDialogToggleEventTask(DialogState oldState, DialogState newState) | |||
There was a problem hiding this comment.
This should be shared somehow with the details / popover code to avoid duplication.
There was a problem hiding this comment.
I had considered this but I also thought it might be better as a follow up PR. Thoughts?
There was a problem hiding this comment.
I would prefer refactoring details / popover first and then adopting the new shared code here.
| queueDialogToggleEventTask(DialogState::Open, DialogState::Closed); | ||
|
|
||
| queueTaskToDispatchEvent(TaskSource::UserInteraction, Event::create(eventNames().closeEvent, Event::CanBubble::No, Event::IsCancelable::No)); |
There was a problem hiding this comment.
the close event should be emitted before toggle, to get consistent event ordering (otherwise toggle might fire first when no coalescing is happening, but after when it isn't)
webkit-ews-buildbot
added
the
merging-blocked
706583c