Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web Inspector: Remove reference to Mojave in WI.undockedTitleAreaHeight() #28331

Merged
merged 1 commit into from May 9, 2024
Merged

Web Inspector: Remove reference to Mojave in WI.undockedTitleAreaHeight() #28331

merged 1 commit into from May 9, 2024

Conversation

aperezdc
Copy link
Contributor

@aperezdc aperezdc commented May 9, 2024 •
edited by webkit-early-warning-system

4e0681f

Web Inspector: Remove reference to Mojave in WI.undockedTitleAreaHeight()
https://bugs.webkit.org/show_bug.cgi?id=273933

Reviewed by Devin Rousso.

* Source/WebInspectorUI/UserInterface/Base/Main.js: Remove reference to
  Mojave, support for which was removed in 242418@main

Canonical link: https://commits.webkit.org/278587@main

d32e75d

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@aperezdc aperezdc self-assigned this May 9, 2024
@aperezdc aperezdc added the Web Inspector Bugs related to the WebKit Web Inspector. label May 9, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 5dad2a9)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
✅ 🛠 watch
✅ 🛠 watch-sim

@aperezdc aperezdc mentioned this pull request May 9, 2024
Merged
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 9, 2024
@csaavedra
Copy link
Member

Can you rebase this? For some reason the base commit is not building in some bots.

@aperezdc aperezdc removed the merging-blocked Applied to prevent a change from being merged label May 9, 2024
@aperezdc aperezdc force-pushed the inspectorfrontend-remove-mojave-reference branch from 5dad2a9 to d32e75d Compare May 9, 2024 16:41
@aperezdc
Copy link
Contributor Author

aperezdc commented May 9, 2024

Can you rebase this? For some reason the base commit is not building in some bots.

Done, let's see what the bots tell this time 😄

@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash d32e75d)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@aperezdc aperezdc added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 9, 2024
@aperezdc
Web Inspector: Remove reference to Mojave in WI.undockedTitleAreaHeig…
4e0681f 
…ht()

https://bugs.webkit.org/show_bug.cgi?id=273933

Reviewed by Devin Rousso.

* Source/WebInspectorUI/UserInterface/Base/Main.js: Remove reference to
  Mojave, support for which was removed in 242418@main

Canonical link: https://commits.webkit.org/278587@main
@webkit-commit-queue webkit-commit-queue force-pushed the inspectorfrontend-remove-mojave-reference branch from d32e75d to 4e0681f Compare May 9, 2024 21:28
@webkit-commit-queue
Copy link
Collaborator

Committed 278587@main (4e0681f): https://commits.webkit.org/278587@main

Reviewed commits have been landed. Closing PR #28331 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 4e0681f into WebKit:main May 9, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcrousso dcrousso dcrousso approved these changes

@patrickangle patrickangle Awaiting requested review from patrickangle patrickangle is a code owner

Assignees

@aperezdc aperezdc

Labels
Web Inspector Bugs related to the WebKit Web Inspector.
Projects
None yet
Milestone
No milestone
6 participants
@aperezdc @webkit-early-warning-system @csaavedra @webkit-commit-queue @dcrousso @webkit-ews-buildbot