Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement delay_on_commit to celery tasks #11624

Merged

Conversation

harriebird
Copy link
Collaborator

Proposed changes

Implement delay_on_commit to celery tasks.
This solves issue #10049.

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

Copy link

codecov bot commented May 12, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 90.62%. Comparing base (6aee586) to head (49410af).
Report is 1733 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11624      +/-   ##
==========================================
- Coverage   90.82%   90.62%   -0.20%     
==========================================
  Files         554      570      +16     
  Lines       57306    58615    +1309     
  Branches     9122     9363     +241     
==========================================
+ Hits        52046    53122    +1076     
- Misses       3640     3809     +169     
- Partials     1620     1684      +64     
Files Coverage Δ
weblate/accounts/models.py 86.89% <100.00%> (-0.28%) ⬇️
weblate/addons/autotranslate.py 84.61% <100.00%> (+6.83%) ⬆️
weblate/trans/models/change.py 82.40% <100.00%> (+3.39%) ⬆️
weblate/trans/models/project.py 91.64% <100.00%> (-1.07%) ⬇️
weblate/trans/models/unit.py 86.15% <100.00%> (-0.15%) ⬇️
weblate/trans/models/component.py 79.38% <50.00%> (-0.57%) ⬇️
weblate/utils/stats.py 93.41% <0.00%> (-0.23%) ⬇️

... and 239 files with indirect coverage changes

@nijel nijel added this to the 5.6 milestone May 13, 2024
@weblateorg-sentry-integration

This comment was marked as off-topic.

@nijel nijel linked an issue May 13, 2024 that may be closed by this pull request
@nijel nijel merged commit 22ddc2d into WeblateOrg:main May 13, 2024
30 of 31 checks passed
@nijel
Copy link
Member

nijel commented May 13, 2024

Merged, thanks for your contribution!

@nijel nijel self-assigned this May 13, 2024
@harriebird harriebird deleted the feature/implement-celery-delay-on-commit branch May 13, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate Celery tasks trigger on_commit
2 participants