fix checksum issue from #196 #197
Open
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhyNotHugo
requested changes
Jun 3, 2023
Comment on lines
+93
to
+94
| evensum = reduce(sum_, self.ean[1:12:2]) | ||
| oddsum = reduce(sum_, self.ean[0:11:2]) |
There was a problem hiding this comment.
This will break some subclasses like EuropeanArticleNumber8. You should use self.digits instead of 12 here.
| return (10 - ((evensum + oddsum * 3) % 10)) % 10 | ||
| evensum = reduce(sum_, self.ean[1:12:2]) | ||
| oddsum = reduce(sum_, self.ean[0:11:2]) | ||
| return (10 - ((oddsum + evensum * 3) % 10)) % 10 |
There was a problem hiding this comment.
Why did you swap the order here? The result should be the same, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #196, there is an issue with the generation of checksums for 13 digit EAN's.
As seen in the except above, the PR here fixes this issue.