Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-redux to v6 #2559

Closed
ragesoss opened this issue Mar 4, 2019 · 3 comments
Closed

Update react-redux to v6 #2559

ragesoss opened this issue Mar 4, 2019 · 3 comments

Comments

@ragesoss
Copy link
Member

ragesoss commented Mar 4, 2019

A new version of react-redux has been released, but our build fails on it: #2558

The new version is probably compatible will our actual app code, but it has a new interface for Context and Provider that affects our tests. So many of the jest specs will need to be update to the new interface.

@hjhimanshu01
Copy link
Contributor

hjhimanshu01 commented Mar 15, 2019

@ragesoss @bwreid , just had a trial of this ,on running the tests bumped into an error

    Method “props” is meant to be run on 1 node. 0 found instead.
at ShallowWrapper.single (node_modules/enzyme/build/ShallowWrapper.js:1958:17)
      at ShallowWrapper.props (node_modules/enzyme/build/ShallowWrapper.js:1225:21)
      at ShallowWrapper.prop (node_modules/enzyme/build/ShallowWrapper.js:1445:21)
      at Object.prop (test/components/settings/add_admin_form.spec.jsx:38:49)

I'm basically passing the store to components via <Provider store={store} ><Component /><Provider> though Apparently , Shallow doesn't allows 2 components to be passed , so it just takes component and returns the error (much harder to comprehend) . Any leads on how to proceed as Shallow is the last one left .

Update : shallow and react-redux seem to have a minor roadblock , watch out the link

reduxjs/react-redux#1161 (comment)

@ragesoss
Copy link
Member Author

Have you looked at the v6 release notes? They seemed helpful in general, although there's no explicit upgrade guide: https://github.com/reduxjs/react-redux/releases

@hjhimanshu01
Copy link
Contributor

@ragesoss , Yeah , referred them and many other docs , have opened a PR for the same , with work in progress , need your reviews on how to solve that particular issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants