Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wikidata values for catalog providers #428

Merged
merged 13 commits into from
Sep 2, 2021
Merged

Wikidata values for catalog providers #428

merged 13 commits into from
Sep 2, 2021

Conversation

marfox
Copy link
Member

@marfox marfox commented Aug 23, 2021

This PR closes #418 .
Please bear in mind that relevant refactoring suggestions from #419 are not yet addressed here: we have opened issues accordingly (#420 #421 #422) and will tackle them as soon as all the new validator features are implemented.

@marfox marfox added this to the Providers milestone Aug 23, 2021
@marfox marfox added this to Upcoming in v2 via automation Aug 23, 2021
@marfox
Copy link
Member Author

marfox commented Aug 31, 2021

@e-dorigatti : friendly ping

Copy link
Collaborator

@e-dorigatti e-dorigatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay! code is fine but return values need to be made consistent with type annotations. you may look into pre-commit to automatically run type checking, linting, formatting, etc. on commit

soweego/validator/checks.py Outdated Show resolved Hide resolved
soweego/validator/checks.py Outdated Show resolved Hide resolved
@marfox
Copy link
Member Author

marfox commented Sep 2, 2021

Many thanks for the review, your feedback is always super constructive and much appreciated.

return values need to be made consistent with type annotations.

Fixed.

you may look into pre-commit to automatically run type checking, linting, formatting, etc. on commit

Very interesting suggestion! We currently have a similar mechanism in place on Travis CI, see this dotfile.
However, it's a bit hacky and doesn't run mypy type hints check.
From a first glimpse, it looks like pre-commit is a much better solution:

@marfox marfox merged commit 2f339cb into master Sep 2, 2021
v2 automation moved this from Upcoming to Done Sep 2, 2021
@marfox marfox deleted the values-for-catalogs branch September 2, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
v2
  
Done
Development

Successfully merging this pull request may close these issues.

Dump Wikidata values that are not in the target catalog
2 participants