Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to github actions #43

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kosarinin
Copy link

@kosarinin kosarinin commented Feb 5, 2022

Hey @mattmcdonald-uk Thank you for creating this package!

I've noticed this package lost its ci build. I assume because of https://earthly.dev/blog/migrating-from-travis/

In this PR the following changes were introduced:

  • Removed travis ci configuration file
  • Travis ci replaced by github actions
  • Updated "Build" badge in the README.md

Thank you!

@kosarinin kosarinin force-pushed the feature/migrate-to-github-actions branch from 398e236 to 57d2c59 Compare February 13, 2022 15:05
@willpower232
Copy link

Have you considered defining the matrix using a shorter form to save a few lines?

https://github.com/SynergiTech/laravel-postal/blob/aa47a609b27560d8657f2ffd071623aa1cb5ad39/.github/workflows/tests.yml#L10-L17

@kosarinin
Copy link
Author

Hey @willpower232 Yes, I considered using a "shorter form" but if we need to match all the requirements from the travis configuration we will have to write the long list of exclude statements which is the same...

@Nks
Copy link

Nks commented Apr 20, 2022

Is there any specific ETA for this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants