Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prebuild for Node on macOS+arm64 and Windows+ia32 #1002

Merged
merged 1 commit into from
Aug 24, 2023
Merged

prebuild for Node on macOS+arm64 and Windows+ia32 #1002

merged 1 commit into from
Aug 24, 2023

Conversation

verhovsky
Copy link
Contributor

No description provided.

@verhovsky verhovsky requested review from JoshuaWise and a team as code owners May 3, 2023 14:40
@verhovsky
Copy link
Contributor Author

verhovsky commented May 3, 2023 •
edited

I was copying your code for a different repo (tree-sitter/node-tree-sitter#128) and noticed that you don't do this.

@verhovsky verhovsky changed the title prebuild for Node on other architectures as well prebuild for Node on Windows+ia32 and macOS+arm64 May 13, 2023
@harryvince
Copy link

+1

@verhovsky verhovsky changed the title prebuild for Node on Windows+ia32 and macOS+arm64 prebuild for Node on macOS+arm64 and Windows+ia32 Jul 22, 2023
@blakebyrnes
Copy link

@mceachen Can this get reviewed? Mac arm builds are no longer being pre-built for regular darwin (only electron darwin).

@0xOlias
Copy link

0xOlias commented Aug 3, 2023

+1

I think this would fix #1027 as well.

@neoxpert neoxpert mentioned this pull request Aug 23, 2023
Closed
@timothymiller
Copy link

Let's get this merged!

This doesn't add any code, just compile flags. Should be an easy job!

@Death666Machine
Copy link

Death666Machine commented Aug 24, 2023 •
edited

This would be so great to get working!

@wezter96
Copy link

Would be amazing if this got reviewed

mceachen
mceachen approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@mceachen mceachen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mceachen mceachen merged commit 37e07d4 into WiseLibs:master Aug 24, 2023
@mceachen
Copy link
Member

(Sorry I missed this PR, thanks!)

@timothymiller
Copy link

Did this PR get reverted? I'm seeing recompiles happen on 8.5.2 on macOS arm64

@verhovsky
Copy link
Contributor Author

verhovsky commented Aug 29, 2023 •
edited

What Node version are you using?

It didn't get reverted. The correct files for macOS arm64 are there on the GitHub Release although the release CI failed to run npm publish which it runs before compiling and uploading those file.

@timothymiller
Copy link

What Node version are you using?

It didn't get reverted. The correct files for macOS arm64 are there on the GitHub Release although the release CI failed to run npm publish which it runs before compiling and uploading those file.

I am running v18.17.1

I notice there are node binaries for node v93, v115, v108, and v99.

Release notes here

@verhovsky
Copy link
Contributor Author

Node 18.7.1 is NODE_MODULE_VERSION 108

https://nodejs.org/en/download/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mceachen mceachen mceachen approved these changes

@JoshuaWise JoshuaWise Awaiting requested review from JoshuaWise JoshuaWise is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@verhovsky @harryvince @blakebyrnes @0xOlias @timothymiller @Death666Machine @wezter96 @mceachen