Fix the infinite loop created by setImmediate() in threads example #564
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update to the
master.js
used in worker threads example.Issue:
The if condition that checks for pending jobs wrapped in the
poll()
function creates an infinite loop by calling itself usingsetImmediate(poll)
when the job queue is empty. This creates a massive unnecessary workload for one or many cores in the CPU. (Comment in #237 )Fix:
Get rid of the
setImmediate(poll)
completely and introduce a function that schedules new jobs manually wheneverasyncQuery()
is called. Workers will remain idle rest of the time.