Expand Death Strike section of Blood DK guide #6767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these aren't wired up to anything, that is the next step
this also adds some extra configuration options to the violation problem list, and to the event order normalizer. the change to the event order normalizer allows moving multiple events via the same spec. this is useful for Bone Shield because a single cast of Marrowrend may generate up to 4 events (apply + 2 stacks or refresh + 3 stacks) and more than that during DRW
* Meteor Stuff * changelog
this has been largely replaced by the DS section
emallson
changed the title
|
(i totally forgot to set a title for this, oops) |
Merged
via the queue into
WoWAnalyzer:dragonflight
with commit May 29, 2024
34454bb
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a pretty hefty section on Runic Power usage to the Blood DK guide, along with some other more core-ish changes:
SuggestionBoxcomponent that can be used in a guide to have high-level suggestions that the user can drill down into for more detailEventOrderNormalizerto allow re-ordering multiple events. See 7e5b8e2 for details on why but tl;dr Blood DK can sometimes log 4-5 events for a single thing that we want to re-order. The default behavior is unchanged, this is strictly opt-in.I am going to work on an APL section for BDK next and then make the guide default.
Screenshots
(The "Usage" subsection currently exists. the top part is new)
Link: http://localhost:3000/report/L8tfjq2vyFxgCNDJ/1-Heroic+Kazzara,+the+Hellforged+-+Kill+(2:28)/8-Zells/standard#prototype