Core: add sniff to check spacing around spread operators #2100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> 1. There should be one space, or a new line + appropriate indentation, before the spread operator. > 2. There should be no space between the spread operator and the variable/function call it applies to. > 3. When combining the spread operator with the reference operator, there should be no space between them. Includes excluding a particular error code from the `Squiz.Functions.FunctionDeclarationArgumentSpacing` sniff to prevent duplicate messages about the same thing. Refs: * https://make.wordpress.org/core/2020/03/20/updating-the-coding-standards-for-modern-php/ - Operators section * https://developer.wordpress.org/coding-standards/wordpress-coding-standards/php/#spread-operator * WordPress/wpcs-docs 105 * WordPress/WordPress-Coding-Standards 1762 * squizlabs/PHP_CodeSniffer 2548 Fixes 1762 Also note: there are currently two PRs open in PHPCS upstream for the `Generic.WhiteSpace.SpreadOperatorSpacingAfter` sniff: * The first - squizlabs/PHP_CodeSniffer 3647 - is inconsequential as it only involves a message tweak. * The second - squizlabs/PHP_CodeSniffer 3694 - is related to PHP 8.1 first class callables and will prevent the sniff from triggering on those.
dingo-d
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes excluding a particular error code from the
Squiz.Functions.FunctionDeclarationArgumentSpacingsniff to prevent duplicate messages about the same thing.Refs:
Fixes #1762
Also note: there are currently two PRs open in PHPCS upstream for the
Generic.WhiteSpace.SpreadOperatorSpacingAftersniff: