Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only major.minor version in 'Tested up to' field #635

Merged
merged 4 commits into from
May 16, 2024

Conversation

pbking
Copy link
Contributor

@pbking pbking commented May 14, 2024

Swap get_bloginfo('version') with custom function that supplies version with major.minor only.

Fixes #523

To Test:
Using CBT update metadata.
Note that the "Tested Up to" shows the version of WordPress being used with only MAJOR.MINOR in style.css and readme.txt

@pbking pbking mentioned this pull request May 14, 2024
Copy link
Contributor

@matiasbenedetto matiasbenedetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a docblock to the function added.
Apart from that it looks good to me.

Copy link
Member

@vcanales vcanales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this function is a great candidate for a unit test, rather than testing it by calling it from another class.

@pbking pbking merged commit d3ffe65 into trunk May 16, 2024
2 checks passed
@pbking pbking deleted the fix/test-wp-version-nopatch branch May 16, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Make sure patch version gets removed when theme is exported
3 participants