Update examples to use wp-scripts 5.0.0 #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaz
changed the title
|
Since this was a large set of changes I additional bumped the plugin versions to |
gziolo
approved these changes
Sep 19, 2019
|
🎉
Yes, I will close that one 👍 |
mkaz
added a commit
to WordPress/gutenberg
that referenced
this pull request
Sep 20, 2019
Updates the examples to use the syntax:
import { ... } from '@wordpress/package';
instead of
const { ... } = wp.package;
This is more consistent and better for webpack and build setup.
The gutenberg-examples repo was already switched to use import syntax
in: WordPress/gutenberg-examples#89
|
I missed one thing when doing review. Those import statements should have the corresponding entries in package.json file in “dependencies” section. |
mkaz
added a commit
to WordPress/gutenberg
that referenced
this pull request
Sep 25, 2019
* Convert examples to use import syntax
Updates the examples to use the syntax:
import { ... } from '@wordpress/package';
instead of
const { ... } = wp.package;
This is more consistent and better for webpack and build setup.
The gutenberg-examples repo was already switched to use import syntax
in: WordPress/gutenberg-examples#89
* Update docs/designers-developers/developers/tutorials/block-tutorial/block-controls-toolbar-and-sidebar.md
Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
* Update docs/designers-developers/developers/tutorials/block-tutorial/creating-dynamic-blocks.md
Co-Authored-By: Chris Van Patten <chris@vanpattenmedia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's do all the updates...
import { ... } from '@wordpress/package'Additionally, I removed the check for
register_block_typefunction, since it is available in WP 5.0+. I don't think it is still necessary to show an example for it.Fixes #88
Fixes #90
Also probably makes PR #87 obsolete.