Date: Optimize the usage of moment-timezone to save some kilobytes (#…

…12356)
WordPress · Nov 28, 2018 · 4512195 · 4512195
1 parent 6e3bb74
commit 4512195
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 19 deletions.
diff --git a/lib/packages-dependencies.php b/lib/packages-dependencies.php
@@ -25,7 +25,6 @@
 	'wp-block-library'                      => array(
 		'editor',
 		'lodash',
-		'moment',
 		'wp-api-fetch',
 		'wp-autop',
 		'wp-blob',

diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/block-library/package.json b/packages/block-library/package.json
@@ -38,9 +38,6 @@
 		"classnames": "^2.2.5",
 		"lodash": "^4.17.10",
 		"memize": "^1.0.5",
-		"moment": "^2.22.1",
-		"querystring": "^0.2.0",
-		"querystringify": "^1.0.0",
 		"url": "^0.11.0"
 	},
 	"devDependencies": {

diff --git a/packages/date/src/index.js b/packages/date/src/index.js
@@ -2,9 +2,11 @@
  * External dependencies
  */
 import momentLib from 'moment';
-import 'moment-timezone';
+import 'moment-timezone/moment-timezone';
 import 'moment-timezone/moment-timezone-utils';
 
+const WP_ZONE = 'WP';
+
 // Changes made here will likely need to be made in `lib/client-assets.php` as
 // well because it uses the `setSettings()` function to change these settings.
 let settings = {
@@ -92,8 +94,8 @@ export function __experimentalGetSettings() {
 function setupWPTimezone() {
 	// Create WP timezone based off dateSettings.
 	momentLib.tz.add( momentLib.tz.pack( {
-		name: 'WP',
-		abbrs: [ 'WP' ],
+		name: WP_ZONE,
+		abbrs: [ WP_ZONE ],
 		untils: [ null ],
 		offsets: [ -settings.timezone.offset * 60 || 0 ],
 	} ) );
@@ -371,8 +373,8 @@ export function dateI18n( dateFormat, dateValue = new Date(), gmt = false ) {
  * @return {boolean} Is in the future.
  */
 export function isInTheFuture( dateValue ) {
-	const now = momentLib.tz( 'WP' );
-	const momentObject = momentLib.tz( dateValue, 'WP' );
+	const now = momentLib.tz( WP_ZONE );
+	const momentObject = momentLib.tz( dateValue, WP_ZONE );
 
 	return momentObject.isAfter( now );
 }
@@ -386,10 +388,10 @@ export function isInTheFuture( dateValue ) {
  */
 export function getDate( dateString ) {
 	if ( ! dateString ) {
-		return momentLib.tz( 'WP' ).toDate();
+		return momentLib.tz( WP_ZONE ).toDate();
 	}
 
-	return momentLib.tz( dateString, 'WP' ).toDate();
+	return momentLib.tz( dateString, WP_ZONE ).toDate();
 }
 
 setupWPTimezone();