implement deps on useDispatchWithMap

This more closely mirrors the original behaviour of withDispatch.
WordPress · Jun 1, 2019 · 6946a6a · 6946a6a
1 parent 50e8a70
commit 6946a6a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/packages/data/src/components/use-dispatch/use-dispatch-with-map.js b/packages/data/src/components/use-dispatch/use-dispatch-with-map.js
@@ -35,10 +35,11 @@ const useIsomorphicLayoutEffect =
  *                                the first argument and the `registry` object
  *                                as the second argument.  Should return an
  *                                object mapping props to functions.
+ * @param {Array}    deps         An array of dependencies for the hook.
  * @return {Object}  An object mapping props to functions created by the passed
  *                   in dispatchMap.
  */
-const useDispatchWithMap = ( dispatchMap ) => {
+const useDispatchWithMap = ( dispatchMap, deps ) => {
 	const registry = useRegistry();
 	const currentDispatchMap = useRef( dispatchMap );
 
@@ -64,7 +65,7 @@ const useDispatchWithMap = ( dispatchMap ) => {
 					.current( registry.dispatch, registry )[ propName ]( ...args );
 			}
 		);
-	}, [ dispatchMap, registry ] );
+	}, [ registry, ...deps ] );
 };
 
 export default useDispatchWithMap;
diff --git a/packages/data/src/components/with-dispatch/index.js b/packages/data/src/components/with-dispatch/index.js
@@ -80,7 +80,7 @@ const withDispatch = ( mapDispatchToProps ) => createHigherOrderComponent(
 				ownProps,
 				registry
 			);
-			const dispatchProps = useDispatchWithMap( mapDispatch );
+			const dispatchProps = useDispatchWithMap( mapDispatch, [] );
 			return <WrappedComponent { ...ownProps } { ...dispatchProps } />;
 		}
 	),