Update package-lock.json
#12340
Closed
Update package-lock.json
#12340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
requested changes
Nov 27, 2018
There was a problem hiding this comment.
We don't want moment-timezone to be bumped to the latest version. There was a fix introduced which increased the size of the library by a factor of 5. See moment/moment-timezone#697 and the file size before and after:
We probably should evaluate whether we can get rid of moment-timezone.
ntwb
added
the
[Status] Blocked
|
Thanks @gziolo I'll get that excluded tomorrow 👍 |
|
We can also land #12356 first and keep the latest version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the
package-lock.jsonfile from the latestnpm installHow has this been tested?
Screenshots
Types of changes
Checklist: