[Monorepo] Move dependencies to root package.json and change yarn to npm #18531

dratwas · 2019-11-14T21:04:31Z

Description

This is a part of the migration of gutenberg-mobile to the gutenberg repo. See #18508

In this PR we reorganize dependencies related to gutenberg-mobile.

We need to get rid of devDependendencies in packages/react-native-editor/package.json since we have a lint script in gutenberg that makes sur no package has devDependencies. We don't want to pollute the root package.json too much for now though as many of those are used for e2e tests and have a non-compatible Apache 2.0 license. We'll want to address that with a separate packages/react-native-e2e-test package.
We also make gutenberg depend on the 3 new packages by adding them as dependencies in package.json. This is the big part, as it literally integrates our react-native libs into the project. For this to work without errors we need to exclude them from the lint, build and tests.
Usual yarn commands ran from gutenberg-mobile are now accessible from gutenbergusing npm run native. For instance: yarn start => npm run native start

We also get rid of unused files and cleaned up a bit. See list of changes.

List of changes

Remove packages/react-native-editor/gutenberg
Remove packages/react-native-editor/symlinked-packages
Remove packages/react-native-editor/symlinked-packages-in-parent
Add 3 new packages in gutenberg: @wordpress/react-native-aztec, @wordpress/react-native-bridge ans @wordpress/react-native-editor and add those as dependencies in the main package.json
Fix lint errors related to those 3 new packages being scanned: add @types/node dependency as we require node.js modules for the i18n script (will be updated later) and npm run lint-types check those imports.
Add jest dependency as npm run test-unit:native is currently failing without it
Updated react-native version to target the same version used in packages/react-native-editor
Updated references of react-native-aztec in the code with @wordpress/react-native-aztec
Updated references of react-native-gutenberg-bridge in the code with @wordpress/react-native-bridge
Move remaining devDependencies from packages/react-native-editor/package.json to dependencies as they are currently required for our build to work properly. Many of those are required for e2e testing and will be moved to it's own package packages/react-native-e2e-tests later.
Updated scripts in packages/react-native-editor/package.json and packages/react-native-aztec/package.json to use npm instead of yarn.
Exclude packages/react-native-* from the linter in .eslintignore
Exclude packages/react-native-* from the build in bin/packages/build.js

How has this been tested?

npm install should install all dependencies
npm run native ... should run a command from react-native-editor package. Building and running the app is still not possible at this stage
npm run native test should run fine (test may fail because of the environment, need to default to android)
npm run test-unit:native should pass
npm run lint should pass. Note that native packages are currently excluded from the linter. We can fix those errors before switching to gutenberg but then it will be harder to merge changes from gutenberg-mobile during the monorepo work

Types of changes

Move dependencies to root package.json from imported packages.

Checklist:

My code is tested.
My code follows the WordPress code style.
My code follows the accessibility standards.
My code has proper inline documentation.
I've included developer documentation if appropriate.
I've updated all React Native files affected by any refactorings/renamings in this PR. .

packages/react-native-aztec/example/package.json

gziolo

What is very concerning here is that individual packages use different versions of libraries that those one resolved in package-lock.json:

react
react-native

gziolo · 2019-11-26T10:22:15Z

In addition, can we avoid using ranges for packages in the root package.json file for both consistency and safety – it helps to ensure we are shipping code tested on a specific configuration which doesn't change so frequently on every single change in the list of dependencies.

dratwas · 2019-12-05T14:50:09Z

In addition, can we avoid using ranges for packages in the root package.json file for both consistency and safety – it helps to ensure we are shipping code tested on a specific configuration which doesn't change so frequently on every single change in the list of dependencies.

Hey @gziolo i hope it is not a problem that I pushed those changes here -#18566
I had to test it somehow since changing versions of react and react-native is really fragile. It was much easier to do these changes there because the iOS app is working. If it is needed I can cherry-pick these changes here as well.

gziolo · 2019-12-06T07:12:03Z

Hey @gziolo i hope it is not a problem that I pushed those changes here -#18566
I had to test it somehow since changing versions of react and react-native is really fragile. It was much easier to do these changes there because the iOS app is working. If it is needed I can cherry-pick these changes here as well.

Whatever works for you best. I don't care as long as at the end of the PR merging it's correct. Can you point me to the commit hash? I can't see the changes applied in #18566. If it helps I can also apply all changes myself on the top of the last PR you have.

dratwas · 2019-12-06T10:01:08Z

Whatever works for you best. I don't care as long as at the end of the PR merging it's correct. Can you point me to the commit hash? I can't see the changes applied in #18566. If it helps I can also apply all changes myself on the top of the last PR you have.

Sorry I haven't pushed the latest commit - 714f079

gziolo · 2019-12-10T15:28:05Z

Whatever works for you best. I don't care as long as at the end of the PR merging it's correct. Can you point me to the commit hash? I can't see the changes applied in #18566. If it helps I can also apply all changes myself on the top of the last PR you have.

Sorry I haven't pushed the latest commit - 714f079

Cool, I left one comment. It looks great otherwise 👍

…d to fix all the errors later on

…ackages build for now

Tug · 2020-01-23T13:24:58Z

I think this is ready for another pass. I must admit there's a lot going on here. I kept the main idea of the PR @dratwas started: basically repair the dependencies and imports so that we can run again native tests.
This is done as both npm run native test and npm run test-unit:native now runs (we'll keep only one later). For this to work we needed the packages/react-native-* dependencies to install whenever someone runs npm install from the root directory. That meant making all our react-native-* packages dependencies of gutenberg, which meant fixing a few things in the gutenberg scripts (lint, build, test).

I have updated the description to give more details about all the changes, feel free to have a look.

There is still a couple errors in the tests. One is a licence check error we could discuss here.
Another one is a regression in an e2e test I haven't solved yet.

@gziolo Do you think you'll have time to give this a look? If not could you ping someone from your team that might have time?

Pinging some mobile devs who might be interested as well @hypest @maxme and @SergioEstevao who has helped on the RN upgrade.

Tug · 2020-01-23T20:51:21Z

Seems those Apache 2.0 licensed dependencies aren't only for e2e tests (appium). @react-native-community/cli is pulling a bunch of them. There's also react-native-video that depends on a couple.

maxme · 2020-01-24T08:12:46Z

@Tug I think we don't bundle @react-native-community/cli, so that's more likely a dev dependency (even if it's not declared like that in the package.json file). Can we double check that and eventually add an exception to the license check script.

About react-native-video, it's MIT, but has a dependency on react-dom which is Apache V2. We should remove the react-dom dependency in our fork of react-native-video. We don't need the feature react-dom brings to react-native-video. More work on our side to maintain the fork, but it's better that finding or rewriting a replacement library.

Tug · 2020-01-24T09:27:50Z

@maxme Ok! I have opened #19861 and #19860 to track those efforts.

Tug · 2020-01-24T10:12:17Z

tsconfig.json

@@ -9,6 +9,7 @@
 		"noEmit": true,
 		"resolveJsonModule": true,
 		"target": "esnext",
+		"types": ["react", "node", "jest", "requestidlecallback"],


I had to limit the types used by tsc, because I had conflicts in @types/react-native such as
node_modules/@types/react-native/globals.d.ts (36,15): Duplicate identifier 'FormData'.
See this discussion DefinitelyTyped/DefinitelyTyped#15960

@aduth, @dsifford or @sirreal – can you do sanity check?

I'd use separate tsconfig files for the browser and native files... Separate them with include and/or exclude properties.

More specifically, I'd keep the main tsconfig.json as-is, and add in a tsconfig.native.json for the native stuff and then just build the project in series.

A better option if you aren't set on the structure is to drop all react-native stuff somewhere with a common parent directory (e.g., packages/react-native/aztec/xxx, packages/react-native/bridge/xxx) and then just drop a tsconfig at packages/react-native/tsconfig.json and let typescript do the rest.

I think the main issue here is that tsc loads everything installed in node_modules/@types by default. And since we added react-native as a dependency, new types are now installed with it that are causing conflicts in the main (web) build. So splitting the tsconfig or adding a new one in our rn package won't address this problem

Which type definitions are conflicting? Sounds like they are defining ambients that are conflicting with node's ambients? There must be a situation where this has affected some other projects as well, no?

I'd be extremely cautious in specifying individual types by name because that could lead to a situation where, if someone were to install a new set of definitions without also including the name of those in the tsconfig, the bug would be difficult to pinpoint.

Additionally, I'm not sure how this would play with definitions that depend on other definitions. You would have to include those as well in your list of types. (i.e., this doesn't scale particularly well).

Suggestions here @DanielRosenwasser?

Yes I have found this issue reported elsewhere online such as on DefinitelyTyped (see first comment).
Here's the full report from running tsc without this line in tsconfig.json:

node_modules/@types/react-native/globals.d.ts:40:15 - error TS2300: Duplicate identifier 'FormData'. 40 declare class FormData { ~~~~~~~~ node_modules/typescript/lib/lib.dom.d.ts:5353:11 5353 interface FormData { ~~~~~~~~ 'FormData' was also declared here. node_modules/typescript/lib/lib.dom.d.ts:5363:13 5363 declare var FormData: { ~~~~~~~~ and here. node_modules/@types/react-native/globals.d.ts:85:5 - error TS2717: Subsequent property declarations must have the same type. Property 'body' must be of type 'string | ArrayBuffer | ArrayBufferView | Blob | FormData | URLSearchParams | ReadableStream<Uint8Array> | null | undefined', but here has type 'string | ArrayBuffer | DataView | Int8Array | Uint8Array | Uint8ClampedArray | Int16Array | Uint16Array | Int32Array | Uint32Array | Float32Array | Float64Array | Blob | FormData | null | undefined'. 85 body?: BodyInit_; ~~~~ node_modules/typescript/lib/lib.dom.d.ts:1413:5 1413 body?: BodyInit | null; ~~~~ 'body' was also declared here. node_modules/@types/react-native/globals.d.ts:111:14 - error TS2300: Duplicate identifier 'RequestInfo'. 111 declare type RequestInfo = Request | string; ~~~~~~~~~~~ node_modules/typescript/lib/lib.dom.d.ts:18568:6 18568 type RequestInfo = Request | string; ~~~~~~~~~~~ 'RequestInfo' was also declared here. node_modules/@types/react-native/globals.d.ts:130:13 - error TS2403: Subsequent variable declarations must have the same type. Variable 'Response' must be of type '{ new (body?: string | ArrayBuffer | ArrayBufferView | Blob | FormData | URLSearchParams | ReadableStream<Uint8Array> | null | undefined, init?: ResponseInit | undefined): Response; prototype: Response; error(): Response; redirect(url: string, status?: number | undefined): Response; }', but here has type '{ new (body?: string | ArrayBuffer | DataView | Int8Array | Uint8Array | Uint8ClampedArray | Int16Array | Uint16Array | Int32Array | Uint32Array | Float32Array | Float64Array | Blob | FormData | null | undefined, init?: ResponseInit | undefined): Response; prototype: Response; error: () => Response; redirect: (url: ...'. 130 declare var Response: { ~~~~~~~~ node_modules/typescript/lib/lib.dom.d.ts:12463:13 12463 declare var Response: { ~~~~~~~~ 'Response' was also declared here. node_modules/@types/react-native/globals.d.ts:253:14 - error TS2300: Duplicate identifier 'XMLHttpRequestResponseType'. 253 declare type XMLHttpRequestResponseType = "" | "arraybuffer" | "blob" | "document" | "json" | "text"; ~~~~~~~~~~~~~~~~~~~~~~~~~~ node_modules/typescript/lib/lib.dom.d.ts:18746:6 18746 type XMLHttpRequestResponseType = "" | "arraybuffer" | "blob" | "document" | "json" | "text"; ~~~~~~~~~~~~~~~~~~~~~~~~~~ 'XMLHttpRequestResponseType' was also declared here. node_modules/@types/react-native/index.d.ts:9417:18 - error TS2717: Subsequent property declarations must have the same type. Property 'geolocation' must be of type 'Geolocation', but here has type 'GeolocationStatic'. 9417 readonly geolocation: Geolocation; ~~~~~~~~~~~ node_modules/typescript/lib/lib.dom.d.ts:10581:14 10581 readonly geolocation: Geolocation; ~~~~~~~~~~~ 'geolocation' was also declared here. node_modules/@types/react-native/index.d.ts:9420:11 - error TS2451: Cannot redeclare block-scoped variable 'navigator'. 9420 const navigator: Navigator; ~~~~~~~~~ node_modules/typescript/lib/lib.dom.d.ts:18152:13 18152 declare var navigator: Navigator; ~~~~~~~~~ 'navigator' was also declared here. node_modules/typescript/lib/lib.dom.d.ts:5353:11 - error TS2300: Duplicate identifier 'FormData'. 5353 interface FormData { ~~~~~~~~ node_modules/@types/react-native/globals.d.ts:40:15 40 declare class FormData { ~~~~~~~~ 'FormData' was also declared here. node_modules/typescript/lib/lib.dom.d.ts:5363:13 - error TS2300: Duplicate identifier 'FormData'. 5363 declare var FormData: { ~~~~~~~~ node_modules/@types/react-native/globals.d.ts:40:15 40 declare class FormData { ~~~~~~~~ 'FormData' was also declared here. node_modules/typescript/lib/lib.dom.d.ts:18152:13 - error TS2451: Cannot redeclare block-scoped variable 'navigator'. 18152 declare var navigator: Navigator; ~~~~~~~~~ node_modules/@types/react-native/index.d.ts:9420:11 9420 const navigator: Navigator; ~~~~~~~~~ 'navigator' was also declared here. node_modules/typescript/lib/lib.dom.d.ts:18568:6 - error TS2300: Duplicate identifier 'RequestInfo'. 18568 type RequestInfo = Request | string; ~~~~~~~~~~~ node_modules/@types/react-native/globals.d.ts:111:14 111 declare type RequestInfo = Request | string; ~~~~~~~~~~~ 'RequestInfo' was also declared here. node_modules/typescript/lib/lib.dom.d.ts:18746:6 - error TS2300: Duplicate identifier 'XMLHttpRequestResponseType'. 18746 type XMLHttpRequestResponseType = "" | "arraybuffer" | "blob" | "document" | "json" | "text"; ~~~~~~~~~~~~~~~~~~~~~~~~~~ node_modules/@types/react-native/globals.d.ts:253:14 253 declare type XMLHttpRequestResponseType = "" | "arraybuffer" | "blob" | "document" | "json" | "text"; ~~~~~~~~~~~~~~~~~~~~~~~~~~ 'XMLHttpRequestResponseType' was also declared here. Found 12 errors.

My only other thought before hearing from Daniel is maybe adding the @types/react-native path to exclude for the browser tsconfig would work if the consensus was to split into separate tsconfig files.

I'd use separate tsconfig files for the browser and native files... Separate them with include and/or exclude properties.

I agree, and I'm more and more convinced that we'll want separate tsconfig files by package. #18942 is one example, and I think we'll see the advantages of fine-grained control over time.

It would be great to see that with test files and jest as well. Being able to grab global describe or it anywhere in the project is a potential source of bugs.

Which type definitions are conflicting? Sounds like they are defining ambients that are conflicting with node's ambients? There must be a situation where this has affected some other projects as well, no?

I've experienced conflicts in another monorepo, and my conclusion was that explicitly defining types becomes necessary. In the monorepo setups I'm familiar with —this one and Calypso— @types are devDependencies, and devDependencies are always root dependencies.

When building multiple packages that target different platforms, it's not surprising that including all root @types in all builds leads to problems and conflicts. The browser, node, and react-native are different platforms and different and conflicting types depending on our target platform seems desirable.

I'd be extremely cautious in specifying individual types by name because that could lead to a situation where, if someone were to install a new set of definitions without also including the name of those in the tsconfig, the bug would be difficult to pinpoint.

Additionally, I'm not sure how this would play with definitions that depend on other definitions. You would have to include those as well in your list of types. (i.e., this doesn't scale particularly well).

My (limited) experience has been that few type declarations are ambient/global, and they should be treated with care. Most package types will be included by explicitly importing the associated module.

I'm a bit surprised by the inclusion of react in this list. Maybe a simpler and more portable JSX import could be used? I'd expect react imports to be included when including @wordpress/element.

I've excluded react-native packages from this tsconfig, eventually we'll have our own tsconfig as we port our code from flow 👍
In the meantime, are we ok to keep those types in? I did not want to introduce a new JSX type here as @types/react is already installed as a dependency but I'm happy to help revisit this in another PR

packages/react-native-aztec/example/editor.js

packages/react-native-aztec/android/settings.gradle

Tug · 2020-01-28T10:29:44Z

packages/react-native-editor/.eslintrc.js

@@ -16,16 +16,11 @@ module.exports = {
 		"react",
 		"react-native",
 		"jest",
-		"flowtype"


I haven't converted flow files to esnext yet but I just wanted to have less dependencies to deal with

dratwas · 2020-01-28T10:47:51Z

LGTM :)
Good work @Tug .

.eslintignore

package.json

packages/react-native-aztec/package.json

packages/react-native-editor/package.json

gziolo · 2020-02-02T19:52:25Z

packages/react-native-editor/package.json

  },
-  "resolutions": {
-    "@react-native-community/cli": "^1.5.2"
+  "scripts": {


A similar question, how do you plan to work with this package given that there is a huge number of scripts? Some of them reference the local node_modules folder but others go two levels up.

I'm not sure yet, that's something we can discuss here or on follow up PRs when we tackle this problem. I think that given the amount of scripts we might want to keep those here for now as to not clutter the main package.json.

Some of them reference the local node_modules folder but others go two levels up.

In theory there should not be any local node_modules folder, since that indicates a conflict. We'll work to fix those conflicts.

test/unit/jest.config.js

gziolo · 2020-02-02T19:54:57Z

tsconfig.json

@@ -9,6 +9,7 @@
 		"noEmit": true,
 		"resolveJsonModule": true,
 		"target": "esnext",
+		"types": ["react", "node", "jest", "requestidlecallback"],


@aduth, @dsifford or @sirreal – can you do sanity check?

gziolo · 2020-02-02T19:57:19Z

webpack.config.js

-	.map( ( packageName ) => packageName.replace( WORDPRESS_NAMESPACE, '' ) );
+	.map( ( packageName ) => packageName.replace( WORDPRESS_NAMESPACE, '' ) )
+	// exclude react-native packages from the main build
+	.filter( ( packageName ) => ! packageName.startsWith( 'react-native' ) );


In the meantime, @youknowriad introduced a list of bundled packages that don't get included:

gutenberg/webpack.config.js

Lines 29 to 37 in feed14a

const BUNDLED_PACKAGES = [ '@wordpress/icons' ];

const gutenbergPackages = Object.keys( dependencies )

.filter(

( packageName ) =>

! BUNDLED_PACKAGES.includes( packageName ) &&

packageName.startsWith( WORDPRESS_NAMESPACE )

)

.map( ( packageName ) => packageName.replace( WORDPRESS_NAMESPACE, '' ) );

Closer to merge, we should consolidate it somehow.

gziolo · 2020-02-02T20:00:24Z

packages/react-native-bridge/package.json

  "peerDependencies": {
-    "react-native": "0.59.0",
-    "react-native-windows": "0.54.0"
+    "react-native": "*"


Should react be listed here as well? I see it listed in another package. Given that RN depends on React, we probably can remove it on another package, what do you think?

I'm not sure to be honest, we haven't used or thought about react-native-bridge as a standalone package. It's still tightly coupled with the main native editor, thus the reason why I replaced the version with "*" here, so we can revisit later.
We could indeed add react here, but I wonder if it would change anything in termes of packages that use this bridge dependency, since react is already a peer dependency of react-native it should display an error or a warning if react is not a dependency.

Indeed react is a dependency of react-native-aztec, so it could probably be removed there. Let's revisit peerDependencies later if that's ok with you?

Sure thing, I just flagged items to go through during the final iteration 👍

packages/react-native-editor/package.json

dratwas added [Status] In Progress Tracking issues with work in progress [Type] Technical Prototype Offers a technical exploration into an idea as an example of what's possible labels Nov 15, 2019

dratwas mentioned this pull request Nov 20, 2019

[Monorepo] Master PR #18508

Merged

21 tasks

dratwas removed the [Status] In Progress Tracking issues with work in progress label Nov 20, 2019

dratwas marked this pull request as ready for review November 20, 2019 10:07

dratwas requested review from ajitbohra and chrisvanpatten as code owners November 20, 2019 10:07

gziolo added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Nov 26, 2019

gziolo reviewed Nov 26, 2019

View reviewed changes

packages/react-native-aztec/example/package.json Outdated Show resolved Hide resolved

gziolo mentioned this pull request Nov 26, 2019

[Monorepo] split gutenberg-mobile to 3 packages - bridge, editor, aztec #18509

Merged

6 tasks

gziolo reviewed Nov 26, 2019

View reviewed changes

Tug changed the base branch from import-mobile-rename-bridge to feat/import-gutenberg-mobile January 6, 2020 16:41

Tug changed the base branch from feat/import-gutenberg-mobile to import-mobile-rename-bridge January 6, 2020 16:44

Tug force-pushed the rnmobile/import-mobile-package-json branch from 38bf6c6 to 6671a16 Compare January 6, 2020 17:01

dratwas requested review from adamsilverstein, aduth, atimmer, daniloercoli, ellatrix, etoledom, jorgefilipecosta, mkaz, mmtr, nerrad and noisysocks as code owners January 6, 2020 17:01

Tug added 5 commits January 21, 2020 21:12

Exclude react-native packages completely from linter checks, will nee…

20de6c6

…d to fix all the errors later on

Move local react-native package dependencies to the right section

da4f747

Fix npm run build: Do not build react-native packages from the main p…

90f29cf

…ackages build for now

Fix main build

7a7281e

Fix npm run test-unit: exclude react native packages

2e7794a

Tug added 2 commits January 23, 2020 20:34

Remove all dependencies that are needed for native e2e testing

4439e25

Add missing dependency for ci

306be8d

Tug reviewed Jan 24, 2020

View reviewed changes

packages/react-native-aztec/example/editor.js Outdated Show resolved Hide resolved

Tug added 2 commits January 24, 2020 11:44

Remove react-native-aztec/example package files

759894b

Revert changes on react-native-aztec example/editor

9a14d97

Tug reviewed Jan 28, 2020

View reviewed changes

packages/react-native-aztec/android/settings.gradle Show resolved Hide resolved

Tug reviewed Jan 28, 2020

View reviewed changes

gziolo reviewed Feb 2, 2020

View reviewed changes

packages/react-native-editor/package.json Outdated Show resolved Hide resolved

Tug added 4 commits February 5, 2020 14:27

Fix package.json errors

90d23ee

Bring back equivalent-key-map to please the CI

9b76079

Fix a bridge import

79e5464

package-lock update

aa94591

Tug merged commit 4c4b66c into feat/import-gutenberg-mobile-no-squash Feb 7, 2020

Tug deleted the rnmobile/import-mobile-package-json branch February 7, 2020 17:18

Tug mentioned this pull request Feb 28, 2020

[Monorepo] fix unit tests #18608

Closed

6 tasks

sirreal mentioned this pull request Apr 1, 2020

Fix the TS used for the GB-Mobile project. #21324

Merged

6 tasks

Tug mentioned this pull request Jun 5, 2020

[Monorepo] Merge to master #22714

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Monorepo] Move dependencies to root package.json and change yarn to npm #18531

[Monorepo] Move dependencies to root package.json and change yarn to npm #18531

dratwas commented Nov 14, 2019 •

edited by Tug

gziolo left a comment

gziolo commented Nov 26, 2019

dratwas commented Dec 5, 2019

gziolo commented Dec 6, 2019 •

edited

dratwas commented Dec 6, 2019 •

edited

gziolo commented Dec 10, 2019

Tug commented Jan 23, 2020 •

edited

Tug commented Jan 23, 2020 •

edited

maxme commented Jan 24, 2020

Tug commented Jan 24, 2020

Tug Jan 24, 2020 •

edited

gziolo Feb 2, 2020

dsifford Feb 2, 2020

Tug Feb 3, 2020

dsifford Feb 3, 2020

dsifford Feb 3, 2020

Tug Feb 3, 2020

dsifford Feb 3, 2020

sirreal Feb 4, 2020

Tug Feb 6, 2020

Tug Jan 28, 2020

dratwas commented Jan 28, 2020

gziolo Feb 2, 2020

Tug Feb 3, 2020

Tug Feb 3, 2020

gziolo Feb 2, 2020

gziolo Feb 2, 2020

gziolo Feb 2, 2020

Tug Feb 3, 2020

Tug Feb 4, 2020

gziolo Feb 4, 2020

	const BUNDLED_PACKAGES = [ '@wordpress/icons' ];

	const gutenbergPackages = Object.keys( dependencies )
	.filter(
	( packageName ) =>
	! BUNDLED_PACKAGES.includes( packageName ) &&
	packageName.startsWith( WORDPRESS_NAMESPACE )
	)
	.map( ( packageName ) => packageName.replace( WORDPRESS_NAMESPACE, '' ) );

[Monorepo] Move dependencies to root package.json and change yarn to npm #18531

[Monorepo] Move dependencies to root package.json and change yarn to npm #18531

Conversation

dratwas commented Nov 14, 2019 • edited by Tug

Description

List of changes

How has this been tested?

Types of changes

Checklist:

gziolo left a comment

Choose a reason for hiding this comment

gziolo commented Nov 26, 2019

dratwas commented Dec 5, 2019

gziolo commented Dec 6, 2019 • edited

dratwas commented Dec 6, 2019 • edited

gziolo commented Dec 10, 2019

Tug commented Jan 23, 2020 • edited

Tug commented Jan 23, 2020 • edited

maxme commented Jan 24, 2020

Tug commented Jan 24, 2020

Tug Jan 24, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dratwas commented Jan 28, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dratwas commented Nov 14, 2019 •

edited by Tug

gziolo commented Dec 6, 2019 •

edited

dratwas commented Dec 6, 2019 •

edited

Tug commented Jan 23, 2020 •

edited

Tug commented Jan 23, 2020 •

edited

Tug Jan 24, 2020 •

edited