Framework: Travis: Avoid skipping Puppeteer download #20547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
Framework
|
Size Change: 0 B Total Size: 866 kB ℹ️ View Unchanged
|
3 tasks
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 2, 2020
jorgefilipecosta
added
the
Backport to WP Beta/RC
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 2, 2020
jorgefilipecosta
removed
the
Backport to WP Beta/RC
aduth
added a commit
that referenced
this pull request
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Slack conversation (link requires registration): https://wordpress.slack.com/archives/C02QB2JS7/p1582927263162900
This pull request seeks to try to address current Travis build failures. It is unclear why the build errors are suddenly occurring, but appear to be related to our configuration for skipping Chromium downloads in non-E2E build jobs. Based on debugging in Slack, it appears the environment variable is suddenly and incorrectly being assigned in the end-to-end build tasks as well, thus causing those jobs to fail (since they rely on the Chromium download).
https://travis-ci.com/WordPress/gutenberg/jobs/292430144
These changes temporarily remove the environment variable. The only downside to this is that builds may take longer in the non-E2E tasks, since the Chromium download is non-negligible and can cause
npm ci(install) to take longer. Depending if this is a temporary Travis issue, it could be reverted at some point in the future. Otherwise, it may be addressed as part of #20215.Testing Instructions:
Travis build should pass.