Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First pass at I18N-specific ESLint rules #20555

Merged
merged 47 commits into from
Apr 2, 2020
Merged

First pass at I18N-specific ESLint rules #20555

merged 47 commits into from
Apr 2, 2020

Commits on Feb 29, 2020

  1. Add new ESLint rule to validate text domains

    @swissspidy
    swissspidy committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    e8656b9 View commit details
    Browse the repository at this point in the history

  2. Enforce @wordpress/valid-text-domain rule for Gutenberg code base

    @swissspidy
    swissspidy committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    80f6b8b View commit details
    Browse the repository at this point in the history

  3. Use messageId and make fixable

    @swissspidy
    swissspidy committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    656ec12 View commit details
    Browse the repository at this point in the history

  4. Add new no-missing-translator-comments rule

    @swissspidy
    swissspidy committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    6beedd1 View commit details
    Browse the repository at this point in the history

  5. Enforce @wordpress/no-missing-translator-comments rule for Gutenber… 

    …g code base
    @swissspidy
    swissspidy committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    d366d59 View commit details
    Browse the repository at this point in the history

  6. Add docs

    @swissspidy
    swissspidy committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    6c4e07c View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2020

  1. Merge master branch and rename rules

    @swissspidy
    swissspidy committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    f1b325b View commit details
    Browse the repository at this point in the history

  2. Implement feedback from code review

    @swissspidy
    swissspidy committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    05ee583 View commit details
    Browse the repository at this point in the history

  3. Rename rule names

    @swissspidy
    swissspidy committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    3af1fb5 View commit details
    Browse the repository at this point in the history

  4. Simplify getting previousArg

    @swissspidy
    swissspidy committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    82c956d View commit details
    Browse the repository at this point in the history

  5. Extract and document utils

    @swissspidy
    swissspidy committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    d611c85 View commit details
    Browse the repository at this point in the history

  6. Combine comments

    @swissspidy
    swissspidy committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    8194ffa View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into add/i18n-eslint-rules

    @swissspidy
    swissspidy committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    be5a596 View commit details
    Browse the repository at this point in the history

  8. Derive allowDefault from allowedTextDomains

    @swissspidy
    swissspidy committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    6125f28 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2020

  1. Merge branch 'master' into add/i18n-eslint-rules

    @swissspidy
    swissspidy committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    797053d View commit details
    Browse the repository at this point in the history

  2. Break early for line number mismatches 

    Co-Authored-By: Andrew Duthie <andrew@andrewduthie.com>
    @swissspidy @aduth
    swissspidy and aduth committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    02e30c4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into add/i18n-eslint-rules

    @swissspidy
    swissspidy committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    225c09d View commit details
    Browse the repository at this point in the history

  4. Support i18n.* usage in new rules

    @swissspidy
    swissspidy committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    11569f3 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2020

  1. Merge branch 'master' into add/i18n-eslint-rules

    @swissspidy
    swissspidy committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    d1b2fec View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2020

  1. Merge branch 'master' into add/i18n-eslint-rules

    @swissspidy
    swissspidy committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    c48aa0a View commit details
    Browse the repository at this point in the history

  2. Add new i18n-no-variables rule

    @swissspidy
    swissspidy committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    9e535ce View commit details
    Browse the repository at this point in the history

  3. Add new i18n-ellipsis rule

    @swissspidy
    swissspidy committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    811c951 View commit details
    Browse the repository at this point in the history

  4. Add new i18n-no-placeholders-only rule

    @swissspidy
    swissspidy committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    210759d View commit details
    Browse the repository at this point in the history

  5. Add new i18n-no-collapsible-whitespace rule

    @swissspidy
    swissspidy committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    4511fd2 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2020

  1. Disable i18n-no-collapsible-whitespace rule for now

    @swissspidy
    swissspidy committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    bee529e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into add/i18n-eslint-rules

    @swissspidy
    swissspidy committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    b2fcda3 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2020

  1. Remove unneded capture group

    @swissspidy
    swissspidy committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    d388f13 View commit details
    Browse the repository at this point in the history

  2. Use Set for list of translation functions

    @swissspidy
    swissspidy committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    67e38e5 View commit details
    Browse the repository at this point in the history

  3. Move const to top scope

    @swissspidy
    swissspidy committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    545790b View commit details
    Browse the repository at this point in the history

  4. Coding standards in code examples

    @swissspidy
    swissspidy committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    05a8920 View commit details
    Browse the repository at this point in the history

  5. Refactor utils to make code more DRY

    @swissspidy
    swissspidy committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    f845bae View commit details
    Browse the repository at this point in the history

  6. Coding standards in test code

    @swissspidy
    swissspidy committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    63c8606 View commit details
    Browse the repository at this point in the history

  7. Remove now unneeded no-restricted-syntax config

    @swissspidy
    swissspidy committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    63fd381 View commit details
    Browse the repository at this point in the history

  8. Add i18n rules to new i18n config

    @swissspidy
    swissspidy committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    e6fe285 View commit details
    Browse the repository at this point in the history

  9. Mark new ruleset as breaking change

    @swissspidy
    swissspidy committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    5ceb0c7 View commit details
    Browse the repository at this point in the history

  10. Update docs

    @swissspidy
    swissspidy committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    a2e16d5 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'master' into add/i18n-eslint-rules

    @swissspidy
    swissspidy committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    4c2d632 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2020

  1. Fix tests

    @swissspidy
    swissspidy committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    5bcac71 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into add/i18n-eslint-rules

    @swissspidy
    swissspidy committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    3c05054 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2020

  1. Rename argument to allowedTextDomain and allow strings and arrays

    @swissspidy
    swissspidy committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    e7187a0 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2020

  1. Merge branch 'master' into add/i18n-eslint-rules

    @swissspidy
    swissspidy committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    887ed2d View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-Authored-By: Andrew Duthie <andrew@andrewduthie.com>
    @swissspidy @aduth
    swissspidy and aduth committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    071e9b8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into add/i18n-eslint-rules

    @swissspidy
    swissspidy committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    a9c2301 View commit details
    Browse the repository at this point in the history

  4. Turn on i18n-no-collapsible-whitespace rule by default

    @swissspidy
    swissspidy committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    948f22a View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2020

  1. Merge branch 'master' into add/i18n-eslint-rules

    @swissspidy
    swissspidy committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    684cc2d View commit details
    Browse the repository at this point in the history

  2. Fix format after applying suggested change

    @swissspidy
    swissspidy committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    dc94c94 View commit details
    Browse the repository at this point in the history

  3. Reset lastIndex after using test() on a regex with global flag

    @swissspidy
    swissspidy committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    6153feb View commit details
    Browse the repository at this point in the history