Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use css-tree for block-editor style transformations (3). #25514

Closed
wants to merge 8 commits into from
Closed

Use css-tree for block-editor style transformations (3). #25514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ea8665f
Use css-tree for block-editor style transformations.
strarsis Sep 21, 2020
0893926
Revert puppeteer config from WSL2 friendly variant.
strarsis Sep 21, 2020
edf6c8a
Remove unused ltrim package.
strarsis Sep 22, 2020
cd093c6
Cosmetic code change.
strarsis Sep 22, 2020
b4b7bc2
Use dist build of css-tree (browser compatibility / linter).
strarsis Sep 22, 2020
62f2fa4
Replace other occurences of css-tree requires with css-tree dist requ…
strarsis Sep 22, 2020
911c4d8
Remove useless empty line at beginning of file.
strarsis Sep 22, 2020
10d9853
Use csstree without dist (to reduce bundle size).
strarsis Sep 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
57 changes: 46 additions & 11 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/block-editor/package.json
View file
Open in desktop
Expand Up @@ -54,9 +54,9 @@
"@wordpress/wordcount": "file:../wordcount",
"classnames": "^2.2.5",
"css-mediaquery": "^0.1.2",
"css-tree": "^1.0.0-alpha.39",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this using an "alpha" version? can we use the latest stable instead?

Copy link
Contributor Author

@strarsis strarsis Sep 22, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this doesn't make sense, css-tree is in use for many years and very stable, see this issue csstree/csstree#134 for having it finally published at least as a beta release now.

"diff": "^4.0.2",
"dom-scroll-into-view": "^1.2.1",
"inherits": "^2.0.3",
"lodash": "^4.17.19",
"memize": "^1.1.0",
"react-autosize-textarea": "^3.0.2",
Expand All @@ -67,7 +67,7 @@
"refx": "^3.0.0",
"rememo": "^3.0.0",
"tinycolor2": "^1.4.1",
"traverse": "^0.6.6"
"whatwg-url": "^8.0.0"
},
"publishConfig": {
"access": "public"
Expand Down
5 changes: 0 additions & 5 deletions packages/block-editor/src/utils/transform-styles/ast/index.js
View file
Open in desktop

This file was deleted.