Store screenshots of CI e2e failures as CI artifacts #26664
Conversation
|
Size Change: +174 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
adamziel
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
adamziel
changed the title
|
This would be great. Any thoughts on the best way to handle storing the images? Committing image files in git usually isn't a great option. I think I remember seeing that github can work with git-lfs, which might be an option, not sure if there's a cost involved: edit: commented too soon, I see this is using artifacts. |
|
@talldan yup I'm trying artifacts for the first pass, I'm open to other options as well. For now I'm just trying it to take the screenshots, somehow the obvious solutions don't seem to work. |
gziolo
added
the
[Type] Automated Testing
adamziel
changed the title
adamziel
force-pushed
the
add/e2e-failures-screenshots
branch
from
11a7597
to
21f4d35
Compare
| } | ||
|
|
||
| /** | ||
| * @copyright Tom Esterez (@testerez) https://github.com/smooth-code/jest-puppeteer/issues/131#issuecomment-424073620 |
There was a problem hiding this comment.
oh, also any concerns about copyright or licensing here?
There was a problem hiding this comment.
After your review I ended up starting from scratch so probably not, however there is still a degree of inspiration so I believe an acknowledgement note would be a nice thing to do.
There was a problem hiding this comment.
CC @testerez - your idea from argos-ci/jest-puppeteer#131 (comment) is pretty awesome and inspired this PR, we would like to include an acknowledgement note - thoughts? :-)
|
Thanks for doing this! ❤️ What do you think about dumping |
|
Really cool, going to be amazingly helpful. Props! |
adamziel
force-pushed
the
add/e2e-failures-screenshots
branch
from
21f4d35
to
c9d9da5
Compare
|
@noisysocks I added capturing HTML snapshots :-) |
adamziel
force-pushed
the
add/e2e-failures-screenshots
branch
from
c9d9da5
to
42c60da
Compare
adamziel
force-pushed
the
add/e2e-failures-screenshots
branch
from
42c60da
to
d0e4737
Compare
|
This is awesome, great addition @adamziel. Major props 💯 |
|
@ellatrix I think what's missing is the setup bit, note how e2e tests use jest.config.js: while performance tests don't: I followed the trail of calls, and it seems like the command that executes these tests is: which makes me believe adding the following line to |
|
@adamziel Thanks! I think I added it correctly here? https://github.com/WordPress/gutenberg/pull/25775/files#diff-099a51d6bcb1f9eae0b587c6857bf79827750ae3dc210db79d736f65b6abc165 |
Description
This PR updates e2e testing workflow to ensure test failures are captured on screenshots for easier debugging.
Testing instructions
This PR purposefully breaks a test to trigger screenshot capture. To see if it works, go to e2e test failures and confirm you can see the following artifact: