Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: output block position for screen readers. Update: refactor the way the screen reader information on block button is delivered. #29060

Closed
wants to merge 46 commits into from
Closed

New: output block position for screen readers. Update: refactor the way the screen reader information on block button is delivered. #29060

wants to merge 46 commits into from

Commits on Feb 16, 2021

  1. i

    Alex Stine committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    bf6325c View commit details
    Browse the repository at this point in the history

  2. Try to import getBlockCount.

    Alex Stine committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    4d711e4 View commit details
    Browse the repository at this point in the history

  3. Try to import getBlockCount.

    Alex Stine committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    112ba24 View commit details
    Browse the repository at this point in the history

  4. Use existing selector.

    Alex Stine committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    06e53a6 View commit details
    Browse the repository at this point in the history

  5. Pass in rootClientId to getBlockCount.

    Alex Stine committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    d8fb0e2 View commit details
    Browse the repository at this point in the history

  6. Pass our new total arg in to the accessible label function.

    Alex Stine committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    bf04b90 View commit details
    Browse the repository at this point in the history

  7. Attempt to fix tests.

    Alex Stine committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    b467a77 View commit details
    Browse the repository at this point in the history

  8. Use description text to output instead of aria-label.

    Alex Stine committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    7e119f9 View commit details
    Browse the repository at this point in the history

  9. A fix to button component to use proper ID passed in to span.

    Alex Stine committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    bb8ac20 View commit details
    Browse the repository at this point in the history

  10. Define custom unique description ID constructed with clientId of block.

    Alex Stine committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    93e5256 View commit details
    Browse the repository at this point in the history

  11. Try to output accessible Block label after block title output.

    Alex Stine committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    0f4dc5a View commit details
    Browse the repository at this point in the history

  12. Render span instead of div.

    Alex Stine committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    bd2f11c View commit details
    Browse the repository at this point in the history

  13. Get rid of duplicate title. Add spacing instead of : .

    Alex Stine committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    8f8e0c0 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2021

  1. Auto format.

    Alex Stine committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    22979b8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/wordpress/gutenberg into … 

    …new/output-block-position-sr
    Alex Stine committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    41259f4 View commit details
    Browse the repository at this point in the history

  3. Test case.

    Alex Stine committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    3da7129 View commit details
    Browse the repository at this point in the history

  4. Modify the accessible description function with parent title.

    Alex Stine committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    6f86d03 View commit details
    Browse the repository at this point in the history

  5. Change text.

    Alex Stine committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    219e94e View commit details
    Browse the repository at this point in the history

  6. Formatting fixes and additional comments.

    Alex Stine committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    4bae102 View commit details
    Browse the repository at this point in the history

  7. No verify.

    Alex Stine committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    5b65ebc View commit details
    Browse the repository at this point in the history

  8. Try to sync package-lock.json with master.

    Alex Stine committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    4b312f9 View commit details
    Browse the repository at this point in the history

  9. Refresh.

    Alex Stine committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    3ef07e1 View commit details
    Browse the repository at this point in the history

  10. Revert package-lock.json to upstream master.

    Alex Stine committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    f5a163e View commit details
    Browse the repository at this point in the history

  11. Use createInterpolateElement for title output.

    Alex Stine committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    15d5381 View commit details
    Browse the repository at this point in the history

  12. Fix title block tests.

    Alex Stine committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    1e4bf55 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2021

  1. Fix title bugs. Output parentTitle in SR block description via sprint… 

    …f with conditionals.
    Alex Stine committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    040516e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/wordpress/gutenberg into … 

    …new/output-block-position-sr
    Alex Stine committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    35e3e53 View commit details
    Browse the repository at this point in the history

  3. Remove mods to button component.

    Alex Stine committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    857265d View commit details
    Browse the repository at this point in the history

  4. Pass rootClientId from selector callback.

    Alex Stine committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    2fdf221 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' of https://github.com/wordpress/gutenberg

    Alex Stine committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    780f2c6 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2021

  1. Remove unused sprintf.

    Alex Stine committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    b6108ef View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2021

  1. Merge branch 'master' of https://github.com/wordpress/gutenberg

    Alex Stine committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    accb462 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2021

  1. Merge branch 'master' of https://github.com/wordpress/gutenberg into … 

    …new/output-block-position-sr
    Alex Stine committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    f040379 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2021

  1. Fix invalid sprintf arg.

    Alex Stine committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    ba88fb9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/wordpress/gutenberg into … 

    …new/output-block-position-sr
    Alex Stine committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    ac76c53 View commit details
    Browse the repository at this point in the history

  3. Fix parentTitle output for blocks with label.

    Alex Stine committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    94387c7 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2021

  1. Give total variable a better descriptive name blocksTotal.

    Alex Stine committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    7fcb514 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/wordpress/gutenberg into … 

    …new/output-block-position-sr
    Alex Stine committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    025c4ad View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2021

  1. Merge branch 'master' of https://github.com/wordpress/gutenberg

    Alex Stine committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    96b20fb View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2021

  1. Refresh.

    Alex Stine committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    4f59b3f View commit details
    Browse the repository at this point in the history

  2. Fix conflict.

    Alex Stine committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    0de9d39 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2021

  1. Merge branch 'trunk' of https://github.com/wordpress/gutenberg into n… 

    …ew/output-block-position-sr
    Alex Stine committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    a0c8034 View commit details
    Browse the repository at this point in the history

  2. Correct error that popped up during merge from trunk.

    Alex Stine committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    32f297c View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2021

  1. Revert changes to title.

    Alex Stine committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    8b4d2ce View commit details
    Browse the repository at this point in the history

  2. Merge branch 'trunk' of https://github.com/wordpress/gutenberg into n… 

    …ew/output-block-position-sr
    Alex Stine committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    0a37674 View commit details
    Browse the repository at this point in the history

  3. Add title back to description.

    Alex Stine committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    2e925b0 View commit details
    Browse the repository at this point in the history