Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .nvmrc to use node 14 #36384

Closed
wants to merge 1 commit into from
Closed

Update .nvmrc to use node 14 #36384

wants to merge 1 commit into from

Conversation

walbo
Copy link
Member

@walbo walbo commented Nov 10, 2021

Description

Latest LTS in now node 16 and ships with npm 8 which uses lock version 2. Using v2 is blocked until #36041 is merged.

Update .nvmrc to use node 14. This the previous LTS version (now a maintenance LTS) and used in all the CI test.

This PR should be reverted once #36041 is merged (or added to that PR).

How has this been tested?

Confirm nvm use in Gutenberg repo sets the proper node/npm versions.

Types of changes

Updates .nvmrc config

@Mamaduka Mamaduka requested a review from gziolo November 12, 2021 07:22
@gziolo
Copy link
Member

gziolo commented Nov 12, 2021

It probably makes sense to keep the version explicit because every time there is s new active LTS version we always need to propagate changes to WordPress core and ensure that the deploy stack is aligned.

The other issue is that we always have to update this lts/* when we create branches for previous major WordPress releases.

@desrosj and @peterwilsoncc since you encounter some issues with it in the past, what do you think?

If we go this route we need to ensure that the documentation for contributors is updated so they are aware which version of Node.js is recommended. We could even send them to the updated file with the note that we aim for the active LTS version but in practice it can diverge. Example:
https://github.com/WordPress/gutenberg/blob/trunk/docs/contributors/code/getting-started-with-code-contribution.md#prerequisites

@gziolo gziolo added the [Type] Build Tooling Issues or PRs related to build tooling label Nov 18, 2021
@gziolo gziolo added this to In progress in Core JS Nov 18, 2021
@gziolo gziolo moved this from In progress to Needs review in Core JS Nov 18, 2021
@gziolo
Copy link
Member

gziolo commented Nov 23, 2021

We landed #36744 that contains the same changes together with all necessary changes to the documentation.

@gziolo gziolo closed this Nov 23, 2021
@gziolo gziolo deleted the update/nvmrc branch November 23, 2021 14:45
@gziolo gziolo moved this from Needs review to Done in Core JS Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling
Projects
No open projects
Core JS
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants