Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP Scripts - Updating Puppeteer #38539

Closed
wants to merge 1 commit into from
Closed

WP Scripts - Updating Puppeteer #38539

wants to merge 1 commit into from

Conversation

Antonio-Laguna
Copy link

Description

Updating puppeteer to the latest version which is 13.1.3. The current version leverages node-fetch with a vulnerability. As per the CHANGELOG even though there are 2 major version leaps, there's nothing that should impact the scripts.

You can see more on puppeteer/puppeteer#7924 and GHSA-r683-j2x4-v87g

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

I've run tests and they're all good. The checklist didn't really apply for this type of change but I've checked the items that felt OK.

@github-actions
Copy link

github-actions bot commented Feb 4, 2022

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Antonio-Laguna! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Feb 4, 2022
@gziolo
Copy link
Member

gziolo commented Feb 6, 2022

Hey, thank you for opening this PR. There already is an open PR #37078 that tries upgrading Puppeteer to the latest version. It would be great to consolidate efforts there. The only remaining blocker was one of the failing tests. We can always temporarily skip it for now if really necessary to remove the vulnerability you mentioned.

@gziolo gziolo mentioned this pull request Feb 6, 2022
7 tasks
@gziolo gziolo added [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Package] Scripts /packages/scripts labels Feb 8, 2022
@gziolo
Copy link
Member

gziolo commented Feb 8, 2022

#37078 is already updated to work with v13.2.0. I'll close this one as a duplicate. Thank you for contribution.

@gziolo gziolo closed this Feb 8, 2022
@gziolo
Copy link
Member

gziolo commented Feb 9, 2022

We are about to land #37078. We should publish changes to npm by tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Scripts /packages/scripts [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants