New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dependency conflicts to allow using NPM 7 and 8 #47712
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 1.31 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of Upgrade node and npm to latest LTS versions.
Allow to use NPM version 7 and 8, and fix the dependency conflicts outlined in #46443.
Why?
The current node version we use in Gutenberg (node 14) is in maintenance and the End-of-life is April, 4th, 2023. In order to use a newer version of node like 16 or 18, we need first to enable NPM 8.
How?
package.json
file.react-native@0.69.4
: This React Native version uses an older React version (18.0.0
), however as explained in this comment, seems safe to override the React version for this dependency. This override could be removed once the React Native version is upgraded to0.71
or above.@testing-library/react-native@11.3.0
: The version of this package uses a newer version of Jest. So far this override doesn't produce failures in mobile unit tests (where the library is used) so seems safe to use this approach. In any case, this override could be removed once we upgrade the Jest version (reference).Testing Instructions
npm i -g npm@8
).npm install
.package-lock.json
file remains unmodified.npm install
again.package-lock.json
file remains unmodified.NOTE: Additional smoke tests in both web and native versions are welcomed to double-check no regressions are introduced.
Warnings displayed when installing dependencies
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A