Add clarification about importing css/scss files #61252
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colorful-tones
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
colorful-tones
added
the
[Type] Developer Documentation
|
Here's the issue that @juanmaguitar added based on my feedback in Slack recently, covering this topic: #61092 |
fabiankaegy
reviewed
Apr 30, 2024
docs/how-to-guides/block-tutorial/applying-styles-with-stylesheets.md
Outdated
Show resolved
Hide resolved
fabiankaegy
approved these changes
May 6, 2024
juanmaguitar
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Additional clarification in Block Editor Handbook / How-to Guides / Blocks / Use styles and stylesheets to remind folks that they will need to
import './editor.scss'in theiredit.js, etc.I've forgotten and missed this rather obvious detail a few times. Also, I requested clarification on this yesterday, which inspired the follow up PR: #54491 (comment)
Why?
Trying to empower folks to understand and use standard approaches.
How?
Clarification in documentation
Preview changes here: https://github.com/WordPress/gutenberg/pull/61252/files#diff-5fa0fb78d92f47c4d5770f668b186c3c3ea593e5fdb2d2b2a8ce3d2f2c775c03