Block Bindings: Add support to all content image and button attributes in block bindings #61255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +30 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
This was referenced May 6, 2024
Open
gziolo
added
[Feature] Block bindings
[Block] Image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add support for the remaining image and button attributes that relate to content:
Why?
Some attributes like
hrefandrelare pretty related, so it makes sense to support all of them for things like pattern overrides.How?
figure > aselector until it is supported by the HTML API.atag and thecaptiontag when their attributes are modified by the bindings. It replicates the logic existing in thesave.jsfile.To do
Testing Instructions
TODO