Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Queue Admin Screen #533

Draft
wants to merge 12 commits into
base: feature/regenerate-existing-images
Choose a base branch
from
Draft

Create Queue Admin Screen #533

wants to merge 12 commits into from

Conversation

ankitrox
Copy link

@ankitrox ankitrox commented Sep 16, 2022 •
edited

Summary

Create an admin screen for managing the jobs in the queue. This is technically managing the terms in background_job taxonomy.

Fixes #491

Relevant technical choices

  1. Add custom menu under tools.php
  2. Customise WP_List_Table to add custom items.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@ankitrox ankitrox added [Focus] Images Issues related to the Images focus area no milestone PRs that do not have a defined milestone for release [Type] Epic A high-level project / epic that will encompass several sub-issues [Module] Regenerate Existing Images Issues for the Regenerate Existing Images module labels Sep 16, 2022
@ankitrox ankitrox self-assigned this Sep 16, 2022
@ankitrox ankitrox linked an issue Sep 16, 2022 that may be closed by this pull request
Create Background Processing Infrastructure: Create Queue Admin Screen #491
Open
@ankitrox
Copy link
Author

ankitrox commented Sep 16, 2022 •
edited

This can be reviewed once the background job class have been merged in feature branch

@ankitrox
Copy link
Author

screenshot-localhost_8888-2022 09 20-21_35_03

Added the placeholder labels for terms. Dynamic labels will be added once the background job class PR gets merged.

CC: @felixarntz @jjgrainger

@ankitrox
Copy link
Author

ankitrox commented Sep 28, 2022 •
edited

Self Note

  1. Replace all instances of background_job with PERFLAB_BACKGROUND_JOB_TAXONOMY_SLUG constant. ✅
  2. Replace get_term_meta calls with proper method by instantiating job object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjgrainger jjgrainger Awaiting requested review from jjgrainger jjgrainger will be requested when the pull request is marked ready for review jjgrainger is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@ankitrox ankitrox

Labels
[Focus] Images Issues related to the Images focus area [Module] Regenerate Existing Images Issues for the Regenerate Existing Images module no milestone PRs that do not have a defined milestone for release [Type] Epic A high-level project / epic that will encompass several sub-issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Background Processing Infrastructure: Create Queue Admin Screen
2 participants
@ankitrox @jjgrainger