Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action for third party library changes #6544

Open
wants to merge 9 commits into
base: trunk
Choose a base branch
from

Conversation

johnbillion
Copy link
Member

Copy link

github-actions bot commented May 13, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @szepeviktor.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props johnbillion.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@szepeviktor
Copy link

@johnbillion This new workflow does not start.
Maybe because "on" event != event_name

@szepeviktor
Copy link

szepeviktor commented May 13, 2024

You can easily debug the current "github" context: https://github.com/szepeviktor/byte-level-care/blob/6aaffb792e2f1e5f535f7bff83a969353d1966cb/.github/workflows/workflow.yml#L48-L63

@szepeviktor
Copy link

@johnbillion I would simply use GH CLI: https://cli.github.com/manual/gh_pr_comment

@johnbillion
Copy link
Member Author

johnbillion commented May 13, 2024

I'm trying to use the same approach as in the other workflows so we don't have too many different implementations of the same thing: https://github.com/WordPress/wordpress-develop/blob/trunk/.github/workflows/pull-request-comments.yml#L165

@szepeviktor

This comment was marked as spam.

@johnbillion
Copy link
Member Author

I think the permissions issue is due to this being a PR from a fork.

@szepeviktor
Copy link

this being a PR from a fork.

You could add && ! github.event.pull_request.head.repo.fork

@johnbillion
Copy link
Member Author

Moved the testing to johnbillion#2

@szepeviktor
Copy link

Instead of escaped backticks you could write: <code>src/wp-includes/Text\</code>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants