Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move puzzle app to a Playground package #1385

Merged
merged 9 commits into from
May 16, 2024
Merged

Move puzzle app to a Playground package #1385

merged 9 commits into from
May 16, 2024

Conversation

bgrgicak
Copy link
Collaborator

@bgrgicak bgrgicak commented May 14, 2024

What is this PR doing?

It moves the Playground puzzle app into a Playground package.

What problem is it solving?

It enables us to deploy the puzzle app to the Playground server.

How is the problem addressed?

By creating a new Playground package and updating the code to work with Vite.

Testing Instructions

  • Follow the readme instructions to start a dev server
  • Setup the puzzle API using these instructions
  • Update this line to point to your development API
  • Open the app and click on Build your site
  • Write one of the action keys like multisite on a piece of paper (text should be clear and bold)
  • Scan it
  • Confirm that an action was added
  • Click on Take me to my site
  • Confirm that the site load and the actions were applied

Note let's address design feedback and improvements in separate PRs to unblock sponsors from updating their blueprints

@bgrgicak bgrgicak self-assigned this May 14, 2024
@bgrgicak bgrgicak marked this pull request as ready for review May 14, 2024 06:08
@bgrgicak bgrgicak requested a review from a team May 14, 2024 06:09
@adamziel
Copy link
Collaborator

adamziel commented May 14, 2024

Unit tests failures are intermittent, but the build failure seems legitimate:

Could not resolve "../node_modules/@wordpress/components/build-style/style.css" from "packages/playground/puzzle/src/index.tsx"

@bgrgicak
Copy link
Collaborator Author

Unit tests failures are intermittent, but the build failure seems legitimate:

Yes, I fixed it now. For some reason, I don't get these errors when I run the commands locally so it may take one or two more attempts.

@adamziel adamziel merged commit 006cb0d into trunk May 16, 2024
5 checks passed
@adamziel adamziel deleted the add/puzzle-app branch May 16, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants