Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DOMParser from Blueprints: installPlugin and installTheme #427

Merged
merged 45 commits into from May 31, 2023
Merged

Remove DOMParser from Blueprints: installPlugin and installTheme #427

merged 45 commits into from May 31, 2023

Commits on May 24, 2023

  1. Rough draft for installPlugin

    @eliot-akira
    eliot-akira committed May 24, 2023
    Configuration menu
    Copy the full SHA
    815acec View commit details
    Browse the repository at this point in the history

  2. Format

    @eliot-akira
    eliot-akira committed May 24, 2023
    Configuration menu
    Copy the full SHA
    61e33f3 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/trunk'

    @eliot-akira
    eliot-akira committed May 24, 2023
    Configuration menu
    Copy the full SHA
    7eb0e26 View commit details
    Browse the repository at this point in the history

  4. Test zip package name different from extracted plugin folder name

    @eliot-akira
    eliot-akira committed May 24, 2023
    Configuration menu
    Copy the full SHA
    304e256 View commit details
    Browse the repository at this point in the history

  5. Remove test plugin after install

    @eliot-akira
    eliot-akira committed May 24, 2023
    Configuration menu
    Copy the full SHA
    9c34cf4 View commit details
    Browse the repository at this point in the history

  6. Use unzip step and find extracted plugin folder name

    @eliot-akira
    eliot-akira committed May 24, 2023
    Configuration menu
    Copy the full SHA
    89a627d View commit details
    Browse the repository at this point in the history

  7. Format

    @eliot-akira
    eliot-akira committed May 24, 2023
    Configuration menu
    Copy the full SHA
    d53a55a View commit details
    Browse the repository at this point in the history

  8. playground.documentRoot getter returns a promise

    @eliot-akira
    eliot-akira committed May 24, 2023
    Configuration menu
    Copy the full SHA
    98cde65 View commit details
    Browse the repository at this point in the history

  9. Remove temporary zip file after extraction

    @eliot-akira
    eliot-akira committed May 24, 2023
    Configuration menu
    Copy the full SHA
    bfaef98 View commit details
    Browse the repository at this point in the history

  10. Format

    @eliot-akira
    eliot-akira committed May 24, 2023
    Configuration menu
    Copy the full SHA
    3f8eb82 View commit details
    Browse the repository at this point in the history

  11. activatePlugin step: await playground.documentRoot because it can ret… 

    …urn promise
    @eliot-akira
    eliot-akira committed May 24, 2023
    Configuration menu
    Copy the full SHA
    f2ed29b View commit details
    Browse the repository at this point in the history

  12. BasePHP: Use FS.rename for method mv

    @eliot-akira
    eliot-akira committed May 24, 2023
    Configuration menu
    Copy the full SHA
    7840907 View commit details
    Browse the repository at this point in the history

  13. Improve error message when extracted plugin folder not found 

    Co-authored-by: Adam Zielinski <adam@adamziel.com>
    @eliot-akira @adamziel
    eliot-akira and adamziel committed May 24, 2023
    Configuration menu
    Copy the full SHA
    daf74b3 View commit details
    Browse the repository at this point in the history

  14. Make server-side test pass: Create plugins folder; Patch VFSResource … 

    …to provide missing method File.arrayBuffer()
    @eliot-akira
    eliot-akira committed May 24, 2023
    Configuration menu
    Copy the full SHA
    82ad36e View commit details
    Browse the repository at this point in the history

  15. Format

    @eliot-akira
    eliot-akira committed May 24, 2023
    Configuration menu
    Copy the full SHA
    3520de3 View commit details
    Browse the repository at this point in the history

  16. Add comment about Gutenberg patch becoming unnecessary as the issue h… 

    …as been fixed upstream
    @eliot-akira
    eliot-akira committed May 24, 2023
    Configuration menu
    Copy the full SHA
    579c568 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. Rewrite installTheme step

    @eliot-akira
    eliot-akira committed May 25, 2023
    Configuration menu
    Copy the full SHA
    534d10f View commit details
    Browse the repository at this point in the history

  2. Format

    @eliot-akira
    eliot-akira committed May 25, 2023
    Configuration menu
    Copy the full SHA
    0615596 View commit details
    Browse the repository at this point in the history

  3. Find plugin entry file to pass to activatePlugin step

    @eliot-akira
    eliot-akira committed May 25, 2023
    Configuration menu
    Copy the full SHA
    11bee55 View commit details
    Browse the repository at this point in the history

  4. activateTheme step: await playground.documentRoot because it can retu… 

    …rn promise
    @eliot-akira
    eliot-akira committed May 25, 2023
    Configuration menu
    Copy the full SHA
    6080b0d View commit details
    Browse the repository at this point in the history

  5. VFSResource: Clean up workaround

    @eliot-akira
    eliot-akira committed May 25, 2023
    Configuration menu
    Copy the full SHA
    fa4f559 View commit details
    Browse the repository at this point in the history

  6. Tests: Clarify comment about zip file names being different from extr… 

    …acted plugin/theme folder name
    @eliot-akira
    eliot-akira committed May 25, 2023
    Configuration menu
    Copy the full SHA
    3fce74e View commit details
    Browse the repository at this point in the history

  7. Remove asDOM helper function, which used DOMParser available only on … 

    …browser side
    @eliot-akira
    eliot-akira committed May 25, 2023
    Configuration menu
    Copy the full SHA
    2b8d31b View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. Remove unnecessary timeout value for tests

    @eliot-akira
    eliot-akira committed May 26, 2023
    Configuration menu
    Copy the full SHA
    e5ae9b5 View commit details
    Browse the repository at this point in the history

  2. Create findPluginEntryFile function for reusable logic

    @eliot-akira
    eliot-akira committed May 26, 2023
    Configuration menu
    Copy the full SHA
    3dbd17a View commit details
    Browse the repository at this point in the history

  3. Remove comment about using plugin/theme upload form, since it's no lo… 

    …nger applicable
    @eliot-akira
    eliot-akira committed May 26, 2023
    Configuration menu
    Copy the full SHA
    ca7b8c1 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'trunk' into remove-dom-parser-from-blueprints

    @eliot-akira
    eliot-akira committed May 26, 2023
    Configuration menu
    Copy the full SHA
    9eed478 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2023

  1. Extract common logic between install plugin/theme into installAsset f… 

    …unction
    @eliot-akira
    eliot-akira committed May 27, 2023
    Configuration menu
    Copy the full SHA
    56cb9d3 View commit details
    Browse the repository at this point in the history

  2. Format

    @eliot-akira
    eliot-akira committed May 27, 2023
    Configuration menu
    Copy the full SHA
    28f7163 View commit details
    Browse the repository at this point in the history

  3. Install asset: Clean up temporary folder before throwing an error

    @eliot-akira
    eliot-akira committed May 27, 2023
    Configuration menu
    Copy the full SHA
    dc05730 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. Clarify comment about JSDOM's File class missing arrayBuffer meth… 

    …od during testing
    @eliot-akira
    eliot-akira committed May 30, 2023
    Configuration menu
    Copy the full SHA
    81bb68f View commit details
    Browse the repository at this point in the history

  2. installAsset: Make generic by replacing assetType with targetPath; Us… 

    …e named type for options
    @eliot-akira
    eliot-akira committed May 30, 2023
    Configuration menu
    Copy the full SHA
    a368526 View commit details
    Browse the repository at this point in the history

  3. Format

    @eliot-akira
    eliot-akira committed May 30, 2023
    Configuration menu
    Copy the full SHA
    7d4f233 View commit details
    Browse the repository at this point in the history

  4. activatePlugin step: Accept path to plugin directory and find plugin … 

    …entry file as needed
    @eliot-akira
    eliot-akira committed May 30, 2023
    Configuration menu
    Copy the full SHA
    30d5c9a View commit details
    Browse the repository at this point in the history

  5. installAsset: Clean up temporary folder and zip file on success or an… 

    …y error
    @eliot-akira
    eliot-akira committed May 30, 2023
    Configuration menu
    Copy the full SHA
    9ed3d75 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2023

  1. Polyfill the File class in JSDOM which lacks arrayBuffer() method

    @eliot-akira
    eliot-akira committed May 31, 2023
    Configuration menu
    Copy the full SHA
    3b67796 View commit details
    Browse the repository at this point in the history

  2. Format

    @eliot-akira
    eliot-akira committed May 31, 2023
    Configuration menu
    Copy the full SHA
    c121866 View commit details
    Browse the repository at this point in the history

  3. activatePlugin: Simplify logic to find plugin entry file

    @eliot-akira
    eliot-akira committed May 31, 2023
    Configuration menu
    Copy the full SHA
    661eda9 View commit details
    Browse the repository at this point in the history

  4. activatePlugin: Simplify logic to find plugin entry file

    @eliot-akira
    eliot-akira committed May 31, 2023
    Configuration menu
    Copy the full SHA
    3cbea6a View commit details
    Browse the repository at this point in the history

  5. activatePlugin: Clarify accepted value for pluginPath option (absolut… 

    …e or relative path)
    @eliot-akira
    eliot-akira committed May 31, 2023
    Configuration menu
    Copy the full SHA
    4487c3a View commit details
    Browse the repository at this point in the history

  6. Merge branch 'trunk' into remove-dom-parser-from-blueprints

    @eliot-akira
    eliot-akira committed May 31, 2023
    Configuration menu
    Copy the full SHA
    6b0f60f View commit details
    Browse the repository at this point in the history

  7. Clean up after merge from trunk

    @eliot-akira
    eliot-akira committed May 31, 2023
    Configuration menu
    Copy the full SHA
    1671b88 View commit details
    Browse the repository at this point in the history

  8. Format

    @eliot-akira
    eliot-akira committed May 31, 2023
    Configuration menu
    Copy the full SHA
    3526f57 View commit details
    Browse the repository at this point in the history

  9. activatePlugin: Use error code for entry file not found; Rethrow any … 

    …PHP error
    @eliot-akira
    eliot-akira committed May 31, 2023
    Configuration menu
    Copy the full SHA
    6f81a34 View commit details
    Browse the repository at this point in the history

  10. Format

    @eliot-akira
    eliot-akira committed May 31, 2023
    Configuration menu
    Copy the full SHA
    977230f View commit details
    Browse the repository at this point in the history