GitHub Export: Use target repo and branch in preview links. #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where the preview links would always point to the upstream repo, even if the changes were pushed to the fork. It also fixes a bug where the preview links would sometimes point to a branch with a different name than the one the changes were pushed to. ## Testing instructions 1. Open Playground, make some changes 2. Click "Export to GitHub" and complete the flow with a repo you have no write access to. Keep this tab open. 3. Click "Preview" in the PR description and verify that it loads Playground with your changes. Then close that tab. 3. In the original Playground tab, make some more changes, click Export to GitHub, select "Update PR", put in the number, then select "Create PR". 4. Complete the flow 5. Click "Preview" in the PR description and verify that it loads Playground
adamziel
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the preview links would always point to the upstream repo, even if the changes were pushed to the fork. It also fixes a bug where the preview links would sometimes point to a branch with a different name than the one the changes were pushed to.
Testing instructions
cc @dmsnell