-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a translations' bulk update tool for the GTE in the Translation Consistency #182
base: trunk
Are you sure you want to change the base?
Conversation
While I can't read the code and can't give you feedback on that... I love the way how Vlad's WPGP tools does it. It also blocks replacements when it's saying "plugin name" or "theme name" It also gives a log file of all the replaced links so, if you did a replace by mistake... you can always go to the log and fix your mistakes easily. Maybe give that a look and who knows, you might have some idea's to improve this. Now, don't misunderstand me... I'm not shooting down this ... this will be an amazing feature... But, WPGP tools has an excellent implementation already and I think we can learn from each other here. |
Can this also be done for 'Formal' as that includes a lot of crap as well. |
This will be only for Spanish and German.... :P I gest, it will be part of the Consistency tool so for all locales and their sublocales. |
And Dutch nl_NL |
User interfaceWhen I started developing this improvement, I reviewed the WPGPTools developed by @vlad-timotei and I liked his approach. I developed something similar, but with checkboxes. After an internal review, we realized that this layout was prone to errors made by the GTE, so we changed the design to one based on select fields, where you have to decide which translation you want for each case, resulting in fewer errors. I think this new user interface is more usable and less error-prone. I like the exception to not including the translation of plugin and theme names. This implementation doesn't open any tab. LogsRelated with the logs, we have two different logs available:
Duplicated localesThe duplicate locales' problem should be resolved in a different PR. There is a Track ticket for this problem. The current PR will work for all locales available in the "Locale" dropdown, so this will not be a problem. |
I have an update to avoid updating the names and authors of themes and plugins. Screenshot in the browser: Screenshot in Matrix: cc @NekoJonez |
One of the most requested functionalities by GTEs is the massive update of translations. We talked about this in this P2: Bulk updates in the Translation Consistency.
This PR adds a new tool, only available for the GTE of each locale, to make bulk updates:
If the logged user is not a GTE, she doesn't get the bulk update form:
Once the GTE makes a bulk update, she gets a list with all the translations and a link to review each new translation.
if you have updated all the strings with the same translation, you are going to see a message like this:
If all the translations are equal, the GTE will not see any form:
Testing
I have tested this PR with the emoji language, to avoid putting fake translations in a real locale. If you are emoji GTE, you can use the next links to test the functionality (if you are GTE in another language, feel free to test it there).
To test it:
Check the translations you want to update.
Select the translation you want to use as replacement.
Click the "Update translations" button.
Follow the links with the updates.
All translations translating the "Continue" word.
All translations translating the "Delete %s" word
<a href="%s">Please update WordPress</a>.
Errors
If the bulk update detects some error, it doesn't make the bulk update and it shows a message like this: